| Message ID | 20231224-n-s5p-mfc-const-v1-3-a3b246470fe4@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e12dcb89e8aa27ed3330ee78e64e9ab1242fe07b |
| Headers | show |
| Series | media: s5p-mfc: cleanups | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 24 December 2023 21:14 > To: Marek Szyprowski <m.szyprowski@samsung.com>; Andrzej Hajda > <andrzej.hajda@intel.com>; Mauro Carvalho Chehab > <mchehab@kernel.org> > Cc: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-fsd@tesla.coma; linux- > samsung-soc@vger.kernel.org; Smitha T Murthy > <smithatmurthy@gmail.com>; linux-arm-kernel@lists.infradead.org; linux- > media@vger.kernel.org; linux-kernel@vger.kernel.org; Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> > Subject: [PATCH 03/15] media: s5p-mfc: drop unused get_*_def_fmt > declarations > > get_dec_def_fmt() and get_enc_def_fmt() do not have definitions, so their > declarations are pointless. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h | 1 - > drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h > b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h > index 0c52ab46cff7..d4310966a0c2 100644 > --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h > +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h > @@ -12,7 +12,6 @@ > const struct s5p_mfc_codec_ops *get_dec_codec_ops(void); struct > vb2_ops *get_dec_queue_ops(void); const struct v4l2_ioctl_ops > *get_dec_v4l2_ioctl_ops(void); -struct s5p_mfc_fmt > *get_dec_def_fmt(bool src); int s5p_mfc_dec_ctrls_setup(struct > s5p_mfc_ctx *ctx); void s5p_mfc_dec_ctrls_delete(struct s5p_mfc_ctx > *ctx); void s5p_mfc_dec_init(struct s5p_mfc_ctx *ctx); diff --git > a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h > b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h > index 3f1b1a037a4f..0cf08b8d40ff 100644 > --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h > +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h > @@ -12,7 +12,6 @@ > const struct s5p_mfc_codec_ops *get_enc_codec_ops(void); struct > vb2_ops *get_enc_queue_ops(void); const struct v4l2_ioctl_ops > *get_enc_v4l2_ioctl_ops(void); -struct s5p_mfc_fmt > *get_enc_def_fmt(bool src); int s5p_mfc_enc_ctrls_setup(struct > s5p_mfc_ctx *ctx); void s5p_mfc_enc_ctrls_delete(struct s5p_mfc_ctx > *ctx); void s5p_mfc_enc_init(struct s5p_mfc_ctx *ctx); > > -- > 2.34.1 Reviewed-by: Aakarsh Jain <aakarsh.jain@samsung.com> Thanks!
diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h index 0c52ab46cff7..d4310966a0c2 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h @@ -12,7 +12,6 @@ const struct s5p_mfc_codec_ops *get_dec_codec_ops(void); struct vb2_ops *get_dec_queue_ops(void); const struct v4l2_ioctl_ops *get_dec_v4l2_ioctl_ops(void); -struct s5p_mfc_fmt *get_dec_def_fmt(bool src); int s5p_mfc_dec_ctrls_setup(struct s5p_mfc_ctx *ctx); void s5p_mfc_dec_ctrls_delete(struct s5p_mfc_ctx *ctx); void s5p_mfc_dec_init(struct s5p_mfc_ctx *ctx); diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h index 3f1b1a037a4f..0cf08b8d40ff 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h @@ -12,7 +12,6 @@ const struct s5p_mfc_codec_ops *get_enc_codec_ops(void); struct vb2_ops *get_enc_queue_ops(void); const struct v4l2_ioctl_ops *get_enc_v4l2_ioctl_ops(void); -struct s5p_mfc_fmt *get_enc_def_fmt(bool src); int s5p_mfc_enc_ctrls_setup(struct s5p_mfc_ctx *ctx); void s5p_mfc_enc_ctrls_delete(struct s5p_mfc_ctx *ctx); void s5p_mfc_enc_init(struct s5p_mfc_ctx *ctx);
get_dec_def_fmt() and get_enc_def_fmt() do not have definitions, so their declarations are pointless. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/media/platform/samsung/s5p-mfc/s5p_mfc_dec.h | 1 - drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.h | 1 - 2 files changed, 2 deletions(-)