[0/2] service: Improve Logging and Event Visibility at the Info Level

Message

Grant Erickson Dec. 23, 2023, 6:58 p.m. UTC

This improves service logging and event visibility at the info level
by making the following additions and changes:

  1. Make log output of online_check_is_enabled_check consistent,
     resulting in log entries similar to "Online check disabled;
     interface wlan0 [ wifi ] remains in ready state."

  2. Log service default, error, and state changes, resulting in log
     entries similar to:

       Interface eth0 [ ethernet ] is the default
       Interface wlan0 [ wifi ] error "online-check-failed"
       Interface wwan0 [ cellular ] state is online

Grant Erickson (2):
  service: Make log output of 'online_check_is_enabled_check'
    consistent.
  service: Log service default, error, and state changes.

 src/service.c | 69 +++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 61 insertions(+), 8 deletions(-)

Comments

Marcel Holtmann Dec. 27, 2023, 11:51 a.m. UTC | #1

Hi Grant,

> This improves service logging and event visibility at the info level
> by making the following additions and changes:
> 
>  1. Make log output of online_check_is_enabled_check consistent,
>     resulting in log entries similar to "Online check disabled;
>     interface wlan0 [ wifi ] remains in ready state."
> 
>  2. Log service default, error, and state changes, resulting in log
>     entries similar to:
> 
>       Interface eth0 [ ethernet ] is the default
>       Interface wlan0 [ wifi ] error "online-check-failed"
>       Interface wwan0 [ cellular ] state is online
> 
> Grant Erickson (2):
>  service: Make log output of 'online_check_is_enabled_check'
>    consistent.
>  service: Log service default, error, and state changes.
> 
> src/service.c | 69 +++++++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 61 insertions(+), 8 deletions(-)

both patches have been applied.

Regards

Marcel