| Message ID | 20231231122019.123344-1-marcin.s.wojtas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5fe65375e3d45b9db11783eea067dfe404752d2f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next:] net: mvpp2: initialize port fwnode pointer | expand |
Looks good to me. >---------------------------------------------------------------------- >Update the port's device structure also with its fwnode pointer with a >recommended device_set_node() helper routine. > >Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com> [Suman] Reviewed-by: Suman Ghosh <sumang@marvell.com> >--- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >index 1ca273f17d29..820b1fabe297 100644 >--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device >*pdev, > dev->min_mtu = ETH_MIN_MTU; > /* 9704 == 9728 - 20 and rounding to 8 */ > dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE; >- dev->dev.of_node = port_node; >+ device_set_node(&dev->dev, port_fwnode); > > port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops; > port->pcs_gmac.neg_mode = true; >-- >2.34.1 >
On Sun, Dec 31, 2023 at 12:20:19PM +0000, Marcin Wojtas wrote: > Update the port's device structure also with its fwnode pointer > with a recommended device_set_node() helper routine. > > Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks!
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 31 Dec 2023 12:20:19 +0000 you wrote: > Update the port's device structure also with its fwnode pointer > with a recommended device_set_node() helper routine. > > Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com> > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next:] net: mvpp2: initialize port fwnode pointer https://git.kernel.org/netdev/net-next/c/5fe65375e3d4 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index 1ca273f17d29..820b1fabe297 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device *pdev, dev->min_mtu = ETH_MIN_MTU; /* 9704 == 9728 - 20 and rounding to 8 */ dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE; - dev->dev.of_node = port_node; + device_set_node(&dev->dev, port_fwnode); port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops; port->pcs_gmac.neg_mode = true;
Update the port's device structure also with its fwnode pointer with a recommended device_set_node() helper routine. Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com> --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)