| Message ID | 20231230053831.67661-1-xiaolei.wang@windriver.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | firmware: imx: scu: ensure wakeup procedure calls pm_system_wakeup() | expand |
Hi Xiaolei, kernel test robot noticed the following build warnings: [auto build test WARNING on shawnguo/for-next] [also build test WARNING on linus/master v6.7-rc7 next-20231222] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Xiaolei-Wang/firmware-imx-scu-ensure-wakeup-procedure-calls-pm_system_wakeup/20231230-134202 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next patch link: https://lore.kernel.org/r/20231230053831.67661-1-xiaolei.wang%40windriver.com patch subject: [PATCH] firmware: imx: scu: ensure wakeup procedure calls pm_system_wakeup() config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20231231/202312310208.zIVggTP2-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231231/202312310208.zIVggTP2-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202312310208.zIVggTP2-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/firmware/imx/imx-scu.c:365:32: warning: 'imx_scu_pm_ops' defined but not used [-Wunused-const-variable=] 365 | static const struct dev_pm_ops imx_scu_pm_ops = { | ^~~~~~~~~~~~~~ vim +/imx_scu_pm_ops +365 drivers/firmware/imx/imx-scu.c 364 > 365 static const struct dev_pm_ops imx_scu_pm_ops = { 366 SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx_scu_suspend_noirq, 367 imx_scu_resume_noirq) 368 }; 369
Hi Xiaolei, kernel test robot noticed the following build warnings: [auto build test WARNING on shawnguo/for-next] [also build test WARNING on linus/master v6.7-rc7 next-20231222] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Xiaolei-Wang/firmware-imx-scu-ensure-wakeup-procedure-calls-pm_system_wakeup/20231230-134202 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next patch link: https://lore.kernel.org/r/20231230053831.67661-1-xiaolei.wang%40windriver.com patch subject: [PATCH] firmware: imx: scu: ensure wakeup procedure calls pm_system_wakeup() config: i386-buildonly-randconfig-003-20231230 (https://download.01.org/0day-ci/archive/20231231/202312310227.7eLUYzgH-lkp@intel.com/config) compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231231/202312310227.7eLUYzgH-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202312310227.7eLUYzgH-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/firmware/imx/imx-scu.c:365:32: warning: unused variable 'imx_scu_pm_ops' [-Wunused-const-variable] 365 | static const struct dev_pm_ops imx_scu_pm_ops = { | ^~~~~~~~~~~~~~ 1 warning generated. vim +/imx_scu_pm_ops +365 drivers/firmware/imx/imx-scu.c 364 > 365 static const struct dev_pm_ops imx_scu_pm_ops = { 366 SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx_scu_suspend_noirq, 367 imx_scu_resume_noirq) 368 }; 369
On 12/31/23 2:55 AM, kernel test robot wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > Hi Xiaolei, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on shawnguo/for-next] > [also build test WARNING on linus/master v6.7-rc7 next-20231222] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Xiaolei-Wang/firmware-imx-scu-ensure-wakeup-procedure-calls-pm_system_wakeup/20231230-134202 > base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next > patch link: https://lore.kernel.org/r/20231230053831.67661-1-xiaolei.wang%40windriver.com > patch subject: [PATCH] firmware: imx: scu: ensure wakeup procedure calls pm_system_wakeup() > config: i386-buildonly-randconfig-003-20231230 (https://download.01.org/0day-ci/archive/20231231/202312310227.7eLUYzgH-lkp@intel.com/config) > compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231231/202312310227.7eLUYzgH-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202312310227.7eLUYzgH-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> drivers/firmware/imx/imx-scu.c:365:32: warning: unused variable 'imx_scu_pm_ops' [-Wunused-const-variable] > 365 | static const struct dev_pm_ops imx_scu_pm_ops = { > | ^~~~~~~~~~~~~~ > 1 warning generated. > > > vim +/imx_scu_pm_ops +365 drivers/firmware/imx/imx-scu.c > > 364 > > 365 static const struct dev_pm_ops imx_scu_pm_ops = { > 366 SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx_scu_suspend_noirq, > 367 imx_scu_resume_noirq) > 368 }; > 369 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki drop this patch, There are still some issues that I will continue to research thanks xiaolei
diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c index 6125cccc9ba7..099a1f50d995 100644 --- a/drivers/firmware/imx/imx-scu-irq.c +++ b/drivers/firmware/imx/imx-scu-irq.c @@ -20,6 +20,7 @@ #define IMX_SC_IRQ_NUM_GROUP 9 static u32 mu_resource_id; +int scu_suspend; struct imx_sc_msg_irq_get_status { struct imx_sc_rpc_msg hdr; @@ -109,7 +110,8 @@ static void imx_scu_irq_work_handler(struct work_struct *work) scu_irq_wakeup[i].wakeup_src = irq_status; } - pm_system_wakeup(); + if (scu_suspend) + pm_system_wakeup(); imx_scu_irq_notifier_call_chain(irq_status, &i); } } diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c index 1dd4362ef9a3..b9f5c5eb4581 100644 --- a/drivers/firmware/imx/imx-scu.c +++ b/drivers/firmware/imx/imx-scu.c @@ -342,10 +342,30 @@ static int imx_scu_probe(struct platform_device *pdev) return devm_of_platform_populate(dev); } + + static const struct of_device_id imx_scu_match[] = { { .compatible = "fsl,imx-scu", }, { /* Sentinel */ } }; +static int __maybe_unused imx_scu_suspend_noirq(struct device *dev) +{ + scu_suspend = true; + + return 0; +} + +static int __maybe_unused imx_scu_resume_noirq(struct device *dev) +{ + scu_suspend = false; + + return 0; +}; + +static const struct dev_pm_ops imx_scu_pm_ops = { + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(imx_scu_suspend_noirq, + imx_scu_resume_noirq) +}; static struct platform_driver imx_scu_driver = { .driver = { diff --git a/include/linux/firmware/imx/sci.h b/include/linux/firmware/imx/sci.h index df17196df5ff..244df9c7629d 100644 --- a/include/linux/firmware/imx/sci.h +++ b/include/linux/firmware/imx/sci.h @@ -17,6 +17,7 @@ #include <linux/firmware/imx/svc/rm.h> #if IS_ENABLED(CONFIG_IMX_SCU) +extern int scu_suspend; int imx_scu_enable_general_irq_channel(struct device *dev); int imx_scu_irq_register_notifier(struct notifier_block *nb); int imx_scu_irq_unregister_notifier(struct notifier_block *nb);
There will still be mu irq in the suspend stage, for example, in imx8. When the system enters the suspend state, the GPIO enters the pad wakeup state. Calling pm_system_wakeup() at this time will cause the system suspend to terminate, so when it is set to wakeup, call pm_system_wakeup(), through rtcwake -s 10 -v -m freeze verification. mxc_gpio_noirq_suspend mxc_gpio_set_pad_wakeup mbox_send_message imx_mu_isr imx_mu_generic_rxdb Fixes: 0caf847975b2 ("firmware: imx: make sure MU irq can wake up system from suspend mode") Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> --- drivers/firmware/imx/imx-scu-irq.c | 4 +++- drivers/firmware/imx/imx-scu.c | 20 ++++++++++++++++++++ include/linux/firmware/imx/sci.h | 1 + 3 files changed, 24 insertions(+), 1 deletion(-)