| Message ID | 20240102220134.3229156-11-samuel.holland@sifive.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | riscv: ASID-related and UP-related TLB flush enhancements | expand |
On Tue, Jan 02, 2024 at 02:00:47PM -0800, Samuel Holland wrote: > This variable is only used inside asids_init(). This is due to patch9, so can be folded into patch9. > > Signed-off-by: Samuel Holland <samuel.holland@sifive.com> > --- > > (no changes since v1) > > arch/riscv/mm/context.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c > index b5170ac1b742..43a8bc2d5af4 100644 > --- a/arch/riscv/mm/context.c > +++ b/arch/riscv/mm/context.c > @@ -20,7 +20,6 @@ > > DEFINE_STATIC_KEY_FALSE(use_asid_allocator); > > -static unsigned long asid_bits; > static unsigned long num_asids; > > static atomic_long_t current_version; > @@ -226,7 +225,7 @@ static inline void set_mm(struct mm_struct *prev, > > static int __init asids_init(void) > { > - unsigned long old; > + unsigned long asid_bits, old; > > /* Figure-out number of ASID bits in HW */ > old = csr_read(CSR_SATP); > -- > 2.42.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On Tue, Jan 2, 2024 at 11:01 PM Samuel Holland <samuel.holland@sifive.com> wrote: > > This variable is only used inside asids_init(). > > Signed-off-by: Samuel Holland <samuel.holland@sifive.com> > --- > > (no changes since v1) > > arch/riscv/mm/context.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c > index b5170ac1b742..43a8bc2d5af4 100644 > --- a/arch/riscv/mm/context.c > +++ b/arch/riscv/mm/context.c > @@ -20,7 +20,6 @@ > > DEFINE_STATIC_KEY_FALSE(use_asid_allocator); > > -static unsigned long asid_bits; > static unsigned long num_asids; > > static atomic_long_t current_version; > @@ -226,7 +225,7 @@ static inline void set_mm(struct mm_struct *prev, > > static int __init asids_init(void) > { > - unsigned long old; > + unsigned long asid_bits, old; > > /* Figure-out number of ASID bits in HW */ > old = csr_read(CSR_SATP); > -- > 2.42.0 > You can add: Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> Thanks, Alex
On 2024-01-03 9:00 AM, Jisheng Zhang wrote: > On Tue, Jan 02, 2024 at 02:00:47PM -0800, Samuel Holland wrote: >> This variable is only used inside asids_init(). > > This is due to patch9, so can be folded into patch9. I'm not sure what you mean here. Patch 9 does not touch any references to the asid_bits variable, though it does touch adjacent lines. >> >> Signed-off-by: Samuel Holland <samuel.holland@sifive.com> >> --- >> >> (no changes since v1) >> >> arch/riscv/mm/context.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c >> index b5170ac1b742..43a8bc2d5af4 100644 >> --- a/arch/riscv/mm/context.c >> +++ b/arch/riscv/mm/context.c >> @@ -20,7 +20,6 @@ >> >> DEFINE_STATIC_KEY_FALSE(use_asid_allocator); >> >> -static unsigned long asid_bits; >> static unsigned long num_asids; >> >> static atomic_long_t current_version; >> @@ -226,7 +225,7 @@ static inline void set_mm(struct mm_struct *prev, >> >> static int __init asids_init(void) >> { >> - unsigned long old; >> + unsigned long asid_bits, old; >> >> /* Figure-out number of ASID bits in HW */ >> old = csr_read(CSR_SATP); >> -- >> 2.42.0 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv
diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c index b5170ac1b742..43a8bc2d5af4 100644 --- a/arch/riscv/mm/context.c +++ b/arch/riscv/mm/context.c @@ -20,7 +20,6 @@ DEFINE_STATIC_KEY_FALSE(use_asid_allocator); -static unsigned long asid_bits; static unsigned long num_asids; static atomic_long_t current_version; @@ -226,7 +225,7 @@ static inline void set_mm(struct mm_struct *prev, static int __init asids_init(void) { - unsigned long old; + unsigned long asid_bits, old; /* Figure-out number of ASID bits in HW */ old = csr_read(CSR_SATP);
This variable is only used inside asids_init(). Signed-off-by: Samuel Holland <samuel.holland@sifive.com> --- (no changes since v1) arch/riscv/mm/context.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)