| Message ID | AS1PR03MB8189F6C1F7DF7907E38198D382672@AS1PR03MB8189.eurprd03.prod.outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | sfp module DFP-34X-2C2 at 2500 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On Thu, Jan 04, 2024 at 02:10:43PM +0100, Sergio Palumbo wrote: > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index 2abc155dc5cf8..a14f61bab256f 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { > // 2500MBd NRZ in their EEPROM > SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), > > + // DFP-34X-2C2 GPON ONU supports 2500base-X > + SFP_QUIRK_M("OEM", "DFP-34X-2C2", sfp_quirk_2500basex), > + > SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), > > // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the > Hi Sergio Please read: https://docs.kernel.org/process/submitting-patches.html and https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html There is a formal process you need to go thought when submitting patches, which these two documents describe. Andrew --- pw-bot: cr
On Thu, Jan 04, 2024 at 03:15:17PM +0100, Andrew Lunn wrote: > On Thu, Jan 04, 2024 at 02:10:43PM +0100, Sergio Palumbo wrote: > > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > > index 2abc155dc5cf8..a14f61bab256f 100644 > > --- a/drivers/net/phy/sfp.c > > +++ b/drivers/net/phy/sfp.c > > @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { > > // 2500MBd NRZ in their EEPROM > > SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), > > > > + // DFP-34X-2C2 GPON ONU supports 2500base-X > > + SFP_QUIRK_M("OEM", "DFP-34X-2C2", sfp_quirk_2500basex), > > + > > SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), > > > > // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the > > > > Hi Sergio > > Please read: > > https://docs.kernel.org/process/submitting-patches.html > > and > > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html > > There is a formal process you need to go thought when submitting > patches, which these two documents describe. Indeed. I assume the original didn't have any commit message, sign-off, and obviously wasn't Cc'd to the appropriate maintainers... It is worth noting that: https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/ gives a table of the possible host interface modes, which appears to includes 2500base-X _with_ AN.
On Thu, Jan 04, 2024 at 02:10:43PM +0100, Sergio Palumbo wrote: > Please use `git format-patch` and send your patch to all receipients listed by `scripts/get_maintainer.pl`. Please also write a meaningful patch description and patch title prefixed similar to other commits adding similar changes to the kernel. > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index 2abc155dc5cf8..a14f61bab256f 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { > // 2500MBd NRZ in their EEPROM > SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), > > + // DFP-34X-2C2 GPON ONU supports 2500base-X > + SFP_QUIRK_M("OEM", "DFP-34X-2C2", sfp_quirk_2500basex), > + > SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), > > // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the >
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 2abc155dc5cf8..a14f61bab256f 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { // 2500MBd NRZ in their EEPROM SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), + // DFP-34X-2C2 GPON ONU supports 2500base-X + SFP_QUIRK_M("OEM", "DFP-34X-2C2", sfp_quirk_2500basex), + SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the