diff mbox series

[4/8] station: add debug events for internal states

Message ID 20240103184638.533221-4-prestwoj@gmail.com (mailing list archive)
State New
Headers show
Series [1/8] station: handle netconfig after roaming for FW roams | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
prestwoj/iwd-ci-gitlint success GitLint

Commit Message

James Prestwood Jan. 3, 2024, 6:46 p.m. UTC
This gives the tests a lot more fine-tune control to wait for
specific state transitions rather than only what is exposed over
DBus.

The additional events for "ft-roam" and "reassoc-roam" were removed
since these are now covered by the more generic state change events
("ft-roaming" and "roaming" respectively).
---
 src/station.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Denis Kenzior Jan. 4, 2024, 5:57 p.m. UTC | #1
Hi James,

On 1/3/24 12:46, James Prestwood wrote:
> This gives the tests a lot more fine-tune control to wait for
> specific state transitions rather than only what is exposed over
> DBus.
> 
> The additional events for "ft-roam" and "reassoc-roam" were removed
> since these are now covered by the more generic state change events
> ("ft-roaming" and "roaming" respectively).
> ---
>   src/station.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 

Applied, thanks.

Regards,
-Denis
diff mbox series

Patch

diff --git a/src/station.c b/src/station.c
index 8f310ec8..79f25d73 100644
--- a/src/station.c
+++ b/src/station.c
@@ -1556,6 +1556,8 @@  static void station_enter_state(struct station *station,
 			station_state_to_string(station->state),
 			station_state_to_string(state));
 
+	station_debug_event(station, station_state_to_string(state));
+
 	disconnected = !station_is_busy(station);
 
 	if ((disconnected && state > STATION_STATE_AUTOCONNECT_FULL) ||
@@ -2222,8 +2224,6 @@  static int station_transition_reassociate(struct station *station,
 	station->preparing_roam = false;
 	station_enter_state(station, STATION_STATE_ROAMING);
 
-	station_debug_event(station, "reassoc-roam");
-
 	return 0;
 }
 
@@ -2366,8 +2366,6 @@  try_next:
 		station->preparing_roam = false;
 		station_enter_state(station, STATION_STATE_FT_ROAMING);
 
-		station_debug_event(station, "ft-roam");
-
 		break;
 	case -EINVAL:
 		/*