mbox series

[0/1] completion: send-email: don't complete revs when --no-format-patch

Message ID 9627364b-c0c9-4b85-a81a-ba1ef0735c9a@smtp-relay.sendinblue.com (mailing list archive)
Headers show
Series completion: send-email: don't complete revs when --no-format-patch | expand

Message

Britton Kerin Jan. 8, 2024, 9:36 a.m. UTC 
Along the way I taught __git_find_last_on_cmdline to understand '--', which
isn't stricly necessary but I think reads more clearly at the call sites.
__git_find_on_cmdline could be changed to work the same, or this part dropped
if people don't like it.

Britton Leo Kerin (1):
  completion: don't comp revs when --no-format-patch

 contrib/completion/git-completion.bash | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)


base-commit: e79552d19784ee7f4bbce278fe25f93fbda196fa
--
2.43.0

Comments

Dragan Simic Jan. 8, 2024, 9:40 a.m. UTC | #1 
On 2024-01-08 10:36, Britton Leo Kerin wrote:
> Along the way I taught __git_find_last_on_cmdline to understand '--', 
> which
> isn't stricly necessary but I think reads more clearly at the call 
> sites.
> __git_find_on_cmdline could be changed to work the same, or this part 
> dropped
> if people don't like it.

If I may suggest, there's no need for a cover letter for a single patch. 
  If you want to include some notes in the patch submission, which aren't 
supposed to be part of the commit summary, you can do that in the patch 
itself.

> Britton Leo Kerin (1):
>   completion: don't comp revs when --no-format-patch
> 
>  contrib/completion/git-completion.bash | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> 
> base-commit: e79552d19784ee7f4bbce278fe25f93fbda196fa
> --
> 2.43.0
Britton Kerin Jan. 8, 2024, 7:34 p.m. UTC | #2 
On Mon, Jan 8, 2024 at 12:40 AM Dragan Simic <dsimic@manjaro.org> wrote:
>
> On 2024-01-08 10:36, Britton Leo Kerin wrote:
> > Along the way I taught __git_find_last_on_cmdline to understand '--',
> > which
> > isn't stricly necessary but I think reads more clearly at the call
> > sites.
> > __git_find_on_cmdline could be changed to work the same, or this part
> > dropped
> > if people don't like it.
>
> If I may suggest, there's no need for a cover letter for a single patch.
>   If you want to include some notes in the patch submission, which aren't
> supposed to be part of the commit summary, you can do that in the patch
> itself.

Ok thanks, I'll do it that way in future.

Britton