diff mbox series

[2/2] net: stmmac: Add StarFive JH8100 dwmac support

Message ID 20240108075810.14161-3-chunhau.tan@starfivetech.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Add StarFive JH8100 dwmac support | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1081 this patch: 1081
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 1108 this patch: 1108
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1108 this patch: 1108
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

ChunHau Tan Jan. 8, 2024, 7:58 a.m. UTC 
Add JH8100 dwmac support.

Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Jan. 8, 2024, 9:07 a.m. UTC | #1 
On 08/01/2024 08:58, Tan Chun Hau wrote:
> Add JH8100 dwmac support.
> 
> Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> index 5d630affb4d1..373714f6e382 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct platform_device *pdev)
>  
>  static const struct of_device_id starfive_dwmac_match[] = {
>  	{ .compatible = "starfive,jh7110-dwmac"	},
> +	{ .compatible = "starfive,jh8100-dwmac"	},

No differences? Then why aren't the devices made compatible with each other?

Best regards,
Krzysztof
ChunHau Tan Jan. 9, 2024, 7:25 a.m. UTC | #2 
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Monday, 8 January, 2024 5:07 PM
> To: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Rob Herring
> <robh+dt@kernel.org>; Emil Renner Berthing <kernel@esmil.dk>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> Conor Dooley <conor+dt@kernel.org>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>; Alexandre Torgue
> <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>;
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney
> <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe
> Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King
> <rmk+kernel@armlinux.org.uk>
> Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support
> 
> On 08/01/2024 08:58, Tan Chun Hau wrote:
> > Add JH8100 dwmac support.
> >
> > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> > index 5d630affb4d1..373714f6e382 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> > @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct
> platform_device *pdev)
> >
> >  static const struct of_device_id starfive_dwmac_match[] = {
> >  	{ .compatible = "starfive,jh7110-dwmac"	},
> > +	{ .compatible = "starfive,jh8100-dwmac"	},
> 
> No differences? Then why aren't the devices made compatible with each
> other?
There is a difference between JH7110 & JH8110,
JH7110 has two reset signals (ahb, stmmaceth),
while JH8110 has only one reset signal (stmmaceth),
this will be shown in device tree file.
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Jan. 9, 2024, 7:58 a.m. UTC | #3 
On 09/01/2024 08:25, ChunHau Tan wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Monday, 8 January, 2024 5:07 PM
>> To: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller
>> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
>> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Rob Herring
>> <robh+dt@kernel.org>; Emil Renner Berthing <kernel@esmil.dk>; Rob Herring
>> <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
>> Conor Dooley <conor+dt@kernel.org>; Maxime Coquelin
>> <mcoquelin.stm32@gmail.com>; Alexandre Torgue
>> <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>;
>> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney
>> <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe
>> Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King
>> <rmk+kernel@armlinux.org.uk>
>> Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
>> <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
>> linux-stm32@st-md-mailman.stormreply.com;
>> linux-arm-kernel@lists.infradead.org
>> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support
>>
>> On 08/01/2024 08:58, Tan Chun Hau wrote:
>>> Add JH8100 dwmac support.
>>>
>>> Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
>>> ---
>>>  drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>>> index 5d630affb4d1..373714f6e382 100644
>>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
>>> @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct
>> platform_device *pdev)
>>>
>>>  static const struct of_device_id starfive_dwmac_match[] = {
>>>  	{ .compatible = "starfive,jh7110-dwmac"	},
>>> +	{ .compatible = "starfive,jh8100-dwmac"	},
>>
>> No differences? Then why aren't the devices made compatible with each
>> other?
> There is a difference between JH7110 & JH8110,
> JH7110 has two reset signals (ahb, stmmaceth),
> while JH8110 has only one reset signal (stmmaceth),
> this will be shown in device tree file.

So if you are so picky then again: No differences in the driver? Then
use compatibility or provide real arguments. NAK.

Best regards,
Krzysztof
ChunHau Tan Jan. 9, 2024, 8:12 a.m. UTC | #4 
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Tuesday, 9 January, 2024 3:59 PM
> To: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Rob Herring
> <robh+dt@kernel.org>; Emil Renner Berthing <kernel@esmil.dk>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> Conor Dooley <conor+dt@kernel.org>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>; Alexandre Torgue
> <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>;
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney
> <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe
> Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King
> <rmk+kernel@armlinux.org.uk>
> Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac support
> 
> On 09/01/2024 08:25, ChunHau Tan wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Monday, 8 January, 2024 5:07 PM
> >> To: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller
> >> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> >> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Rob
> >> Herring <robh+dt@kernel.org>; Emil Renner Berthing <kernel@esmil.dk>;
> >> Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> >> <krzysztof.kozlowski+dt@linaro.org>;
> >> Conor Dooley <conor+dt@kernel.org>; Maxime Coquelin
> >> <mcoquelin.stm32@gmail.com>; Alexandre Torgue
> >> <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>;
> >> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney
> >> <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe
> >> Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King
> >> <rmk+kernel@armlinux.org.uk>
> >> Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> >> <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org;
> >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> linux-stm32@st-md-mailman.stormreply.com;
> >> linux-arm-kernel@lists.infradead.org
> >> Subject: Re: [PATCH 2/2] net: stmmac: Add StarFive JH8100 dwmac
> >> support
> >>
> >> On 08/01/2024 08:58, Tan Chun Hau wrote:
> >>> Add JH8100 dwmac support.
> >>>
> >>> Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> >>> ---
> >>>  drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >> b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> index 5d630affb4d1..373714f6e382 100644
> >>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
> >>> @@ -146,6 +146,7 @@ static int starfive_dwmac_probe(struct
> >> platform_device *pdev)
> >>>
> >>>  static const struct of_device_id starfive_dwmac_match[] = {
> >>>  	{ .compatible = "starfive,jh7110-dwmac"	},
> >>> +	{ .compatible = "starfive,jh8100-dwmac"	},
> >>
> >> No differences? Then why aren't the devices made compatible with each
> >> other?
> > There is a difference between JH7110 & JH8110,
> > JH7110 has two reset signals (ahb, stmmaceth), while JH8110 has only
> > one reset signal (stmmaceth), this will be shown in device tree file.
> 
> So if you are so picky then again: No differences in the driver? Then use
> compatibility or provide real arguments. NAK.
There are no differences in the driver.
Okay, the driver will remain the same, I will drop this change in V2. 
Thank you for the feedback.
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
index 5d630affb4d1..373714f6e382 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c
@@ -146,6 +146,7 @@  static int starfive_dwmac_probe(struct platform_device *pdev)
 
 static const struct of_device_id starfive_dwmac_match[] = {
 	{ .compatible = "starfive,jh7110-dwmac"	},
+	{ .compatible = "starfive,jh8100-dwmac"	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, starfive_dwmac_match);