diff mbox series

[1/2] dt-bindings: net: starfive,jh7110-dwmac: Add StarFive JH8100 support

Message ID 20240108075810.14161-2-chunhau.tan@starfivetech.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series Add StarFive JH8100 dwmac support | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 52 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

ChunHau Tan Jan. 8, 2024, 7:58 a.m. UTC 
Add StarFive JH8100 dwmac support.
JH8100 dwmac has one reset signal instead of 2 resets as in JH7110.

Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
---
 .../bindings/net/starfive,jh7110-dwmac.yaml   | 28 ++++++++++++-------
 1 file changed, 18 insertions(+), 10 deletions(-)

Comments

Krzysztof Kozlowski Jan. 8, 2024, 8:27 a.m. UTC | #1 
On 08/01/2024 08:58, Tan Chun Hau wrote:
> Add StarFive JH8100 dwmac support.
> JH8100 dwmac has one reset signal instead of 2 resets as in JH7110.
> 
> Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> ---
>  .../bindings/net/starfive,jh7110-dwmac.yaml   | 28 ++++++++++++-------
>  1 file changed, 18 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> index 5e7cfbbebce6..3d0447726902 100644
> --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> @@ -17,6 +17,7 @@ select:
>        contains:
>          enum:
>            - starfive,jh7110-dwmac
> +          - starfive,jh8100-dwmac

I have doubts that you tested it. Missing change to snps,dwmac.

>    required:
>      - compatible
>  
> @@ -25,6 +26,7 @@ properties:
>      items:
>        - enum:
>            - starfive,jh7110-dwmac
> +          - starfive,jh8100-dwmac
>        - const: snps,dwmac-5.20
>  
>    reg:
> @@ -54,16 +56,6 @@ properties:
>      minItems: 3
>      maxItems: 3
>  
> -  resets:
> -    items:
> -      - description: MAC Reset signal.
> -      - description: AHB Reset signal.
> -
> -  reset-names:
> -    items:
> -      - const: stmmaceth
> -      - const: ahb
> -
>    starfive,tx-use-rgmii-clk:
>      description:
>        Tx clock is provided by external rgmii clock.
> @@ -93,6 +85,22 @@ required:
>  
>  allOf:
>    - $ref: snps,dwmac.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - starfive,jh7110-dwmac
> +    then:
> +      properties:
> +        resets:
> +          items:
> +            - description: MAC Reset signal.
> +            - description: AHB Reset signal.
> +        resets-names:
> +          items:
> +            - const: stmmaceth
> +            - const: ahb

Missing else: narrowing your jh8100.

Best regards,
Krzysztof
ChunHau Tan Jan. 9, 2024, 7:27 a.m. UTC | #2 
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Monday, 8 January, 2024 4:28 PM
> To: ChunHau Tan <chunhau.tan@starfivetech.com>; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Rob Herring
> <robh+dt@kernel.org>; Emil Renner Berthing <kernel@esmil.dk>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> Conor Dooley <conor+dt@kernel.org>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>; Alexandre Torgue
> <alexandre.torgue@foss.st.com>; Simon Horman <horms@kernel.org>;
> Bartosz Golaszewski <bartosz.golaszewski@linaro.org>; Andrew Halaney
> <ahalaney@redhat.com>; Jisheng Zhang <jszhang@kernel.org>; Uwe
> Kleine-König <u.kleine-koenig@pengutronix.de>; Russell King
> <rmk+kernel@armlinux.org.uk>
> Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> <jeeheng.sia@starfivetech.com>; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-stm32@st-md-mailman.stormreply.com;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add
> StarFive JH8100 support
> 
> On 08/01/2024 08:58, Tan Chun Hau wrote:
> > Add StarFive JH8100 dwmac support.
> > JH8100 dwmac has one reset signal instead of 2 resets as in JH7110.
> >
> > Signed-off-by: Tan Chun Hau <chunhau.tan@starfivetech.com>
> > ---
> >  .../bindings/net/starfive,jh7110-dwmac.yaml   | 28 ++++++++++++-------
> >  1 file changed, 18 insertions(+), 10 deletions(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > index 5e7cfbbebce6..3d0447726902 100644
> > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > +++
> b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > @@ -17,6 +17,7 @@ select:
> >        contains:
> >          enum:
> >            - starfive,jh7110-dwmac
> > +          - starfive,jh8100-dwmac
> 
> I have doubts that you tested it. Missing change to snps,dwmac.
Will fix in V2.
> 
> >    required:
> >      - compatible
> >
> > @@ -25,6 +26,7 @@ properties:
> >      items:
> >        - enum:
> >            - starfive,jh7110-dwmac
> > +          - starfive,jh8100-dwmac
> >        - const: snps,dwmac-5.20
> >
> >    reg:
> > @@ -54,16 +56,6 @@ properties:
> >      minItems: 3
> >      maxItems: 3
> >
> > -  resets:
> > -    items:
> > -      - description: MAC Reset signal.
> > -      - description: AHB Reset signal.
> > -
> > -  reset-names:
> > -    items:
> > -      - const: stmmaceth
> > -      - const: ahb
> > -
> >    starfive,tx-use-rgmii-clk:
> >      description:
> >        Tx clock is provided by external rgmii clock.
> > @@ -93,6 +85,22 @@ required:
> >
> >  allOf:
> >    - $ref: snps,dwmac.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - starfive,jh7110-dwmac
> > +    then:
> > +      properties:
> > +        resets:
> > +          items:
> > +            - description: MAC Reset signal.
> > +            - description: AHB Reset signal.
> > +        resets-names:
> > +          items:
> > +            - const: stmmaceth
> > +            - const: ahb
> 
> Missing else: narrowing your jh8100.
Will fix in V2.
> 
> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
index 5e7cfbbebce6..3d0447726902 100644
--- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
@@ -17,6 +17,7 @@  select:
       contains:
         enum:
           - starfive,jh7110-dwmac
+          - starfive,jh8100-dwmac
   required:
     - compatible
 
@@ -25,6 +26,7 @@  properties:
     items:
       - enum:
           - starfive,jh7110-dwmac
+          - starfive,jh8100-dwmac
       - const: snps,dwmac-5.20
 
   reg:
@@ -54,16 +56,6 @@  properties:
     minItems: 3
     maxItems: 3
 
-  resets:
-    items:
-      - description: MAC Reset signal.
-      - description: AHB Reset signal.
-
-  reset-names:
-    items:
-      - const: stmmaceth
-      - const: ahb
-
   starfive,tx-use-rgmii-clk:
     description:
       Tx clock is provided by external rgmii clock.
@@ -93,6 +85,22 @@  required:
 
 allOf:
   - $ref: snps,dwmac.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - starfive,jh7110-dwmac
+    then:
+      properties:
+        resets:
+          items:
+            - description: MAC Reset signal.
+            - description: AHB Reset signal.
+        resets-names:
+          items:
+            - const: stmmaceth
+            - const: ahb
 
 unevaluatedProperties: false