| Message ID | 20231221073558.3181911-1-Vijendar.Mukunda@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | soundwire/SOF: add SoundWire Interface support for AMD SOF stack | expand |
On 12/21/23 08:35, Vijendar Mukunda wrote: > This patch series is to redesign existing platform device > creation logic for SoundWire managers and Implement generic > functions for SoundWire manager probe, start and exit sequence > which are common for both Legacy(NO DSP enabled) and SOF stack, > and add SoundWire Interface support for AMD SOF stack > (ACP 6.3 based platforms). > > Vijendar Mukunda (12): > ASoC/soundwire: implement generic api for scanning amd soundwire > controller > drivers: soundwire: refactor amd soundwire manager device node > creation > drivers: soundwire: implement function to extract slave information > drivers: soundwire: refactor soundwire pads enable > drivers: soundwire: refactor register mask structure > ASoC: SOF: amd: add code for invoking soundwire manager helper > functions > ASoC: SOF: amd: add interrupt handling for SoundWire manager devices > ASoC: SOF: amd: Add Soundwire DAI configuration support for AMD > platforms > ASoC: SOF: amd: add machine select logic for soundwire based platforms > ASoC: SOF: amd: update descriptor fields for acp6.3 based platform > ASoC: SOF: amd: select soundwire dependency flag for acp6.3 based > platform > ASoC: SOF: amd: refactor acp driver pm ops This patchset was reviewed by Bard and I in https://github.com/thesofproject/linux/pull/4699 That said, my recommendation was to wait 2024 to send those patches, it's rather late for code across two subsystems to be added. > drivers/soundwire/Makefile | 2 +- > drivers/soundwire/amd_init.c | 235 +++++++++++++++++++++++++++++ > drivers/soundwire/amd_init.h | 13 ++ > drivers/soundwire/amd_manager.c | 41 +---- > drivers/soundwire/amd_manager.h | 12 +- > include/linux/soundwire/sdw_amd.h | 79 ++++++++-- > include/sound/sof/dai-amd.h | 7 + > include/sound/sof/dai.h | 2 + > include/uapi/sound/sof/tokens.h | 4 + > sound/soc/amd/acp/Kconfig | 7 + > sound/soc/amd/acp/Makefile | 2 + > sound/soc/amd/acp/amd-sdw-acpi.c | 62 ++++++++ > sound/soc/sof/amd/Kconfig | 18 +++ > sound/soc/sof/amd/acp-common.c | 65 +++++++- > sound/soc/sof/amd/acp-dsp-offset.h | 10 ++ > sound/soc/sof/amd/acp.c | 202 ++++++++++++++++++++++++- > sound/soc/sof/amd/acp.h | 26 +++- > sound/soc/sof/amd/pci-acp63.c | 7 + > sound/soc/sof/ipc3-pcm.c | 25 +++ > sound/soc/sof/ipc3-topology.c | 40 +++++ > sound/soc/sof/sof-audio.h | 1 + > sound/soc/sof/topology.c | 5 + > 22 files changed, 798 insertions(+), 67 deletions(-) > create mode 100644 drivers/soundwire/amd_init.c > create mode 100644 drivers/soundwire/amd_init.h > create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c >
On 21/12/23 13:05, Vijendar Mukunda wrote: > This patch series is to redesign existing platform device > creation logic for SoundWire managers and Implement generic > functions for SoundWire manager probe, start and exit sequence > which are common for both Legacy(NO DSP enabled) and SOF stack, > and add SoundWire Interface support for AMD SOF stack > (ACP 6.3 based platforms). > > Vijendar Mukunda (12): > ASoC/soundwire: implement generic api for scanning amd soundwire > controller > > drivers: soundwire: implement function to extract slave information > drivers: soundwire: refactor soundwire pads enable > drivers: soundwire: refactor register mask structure > ASoC: SOF: amd: add code for invoking soundwire manager helper > functions > ASoC: SOF: amd: add interrupt handling for SoundWire manager devices > ASoC: SOF: amd: Add Soundwire DAI configuration support for AMD > platforms > ASoC: SOF: amd: add machine select logic for soundwire based platforms > ASoC: SOF: amd: update descriptor fields for acp6.3 based platform > ASoC: SOF: amd: select soundwire dependency flag for acp6.3 based > platform > ASoC: SOF: amd: refactor acp driver pm ops We need to post v2 version patch set. There are few patch dependencies. "drivers: soundwire: refactor amd soundwire manager device node creation" patch has dependency on "ASoC/soundwire: implement generic api for scanning amd soundwire controller" SOF patch " ASoC: SOF: amd: add code for invoking soundwire manager helper functions" has dependency on SoundWire patch set. As this patch series has to go in two different sub systems, Please suggest how can we push the patch series to get it reviewed and merged at one go. > > drivers/soundwire/Makefile | 2 +- > drivers/soundwire/amd_init.c | 235 +++++++++++++++++++++++++++++ > drivers/soundwire/amd_init.h | 13 ++ > drivers/soundwire/amd_manager.c | 41 +---- > drivers/soundwire/amd_manager.h | 12 +- > include/linux/soundwire/sdw_amd.h | 79 ++++++++-- > include/sound/sof/dai-amd.h | 7 + > include/sound/sof/dai.h | 2 + > include/uapi/sound/sof/tokens.h | 4 + > sound/soc/amd/acp/Kconfig | 7 + > sound/soc/amd/acp/Makefile | 2 + > sound/soc/amd/acp/amd-sdw-acpi.c | 62 ++++++++ > sound/soc/sof/amd/Kconfig | 18 +++ > sound/soc/sof/amd/acp-common.c | 65 +++++++- > sound/soc/sof/amd/acp-dsp-offset.h | 10 ++ > sound/soc/sof/amd/acp.c | 202 ++++++++++++++++++++++++- > sound/soc/sof/amd/acp.h | 26 +++- > sound/soc/sof/amd/pci-acp63.c | 7 + > sound/soc/sof/ipc3-pcm.c | 25 +++ > sound/soc/sof/ipc3-topology.c | 40 +++++ > sound/soc/sof/sof-audio.h | 1 + > sound/soc/sof/topology.c | 5 + > 22 files changed, 798 insertions(+), 67 deletions(-) > create mode 100644 drivers/soundwire/amd_init.c > create mode 100644 drivers/soundwire/amd_init.h > create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c >
On Tue, Jan 09, 2024 at 06:11:18PM +0530, Mukunda,Vijendar wrote: > SOF patch " ASoC: SOF: amd: add code for invoking soundwire manager > helper functions" has dependency on SoundWire patch set. > As this patch series has to go in two different sub systems, > Please suggest how can we push the patch series to get it reviewed and merged > at one go. I'd expect Vinod to review the Soundwire bits and either ack them or provide a pull request with them that I can fetch into the ASoC tree.
This patch series is to redesign existing platform device creation logic for SoundWire managers and Implement generic functions for SoundWire manager probe, start and exit sequence which are common for both Legacy(NO DSP enabled) and SOF stack, and add SoundWire Interface support for AMD SOF stack (ACP 6.3 based platforms). Vijendar Mukunda (12): ASoC/soundwire: implement generic api for scanning amd soundwire controller drivers: soundwire: refactor amd soundwire manager device node creation drivers: soundwire: implement function to extract slave information drivers: soundwire: refactor soundwire pads enable drivers: soundwire: refactor register mask structure ASoC: SOF: amd: add code for invoking soundwire manager helper functions ASoC: SOF: amd: add interrupt handling for SoundWire manager devices ASoC: SOF: amd: Add Soundwire DAI configuration support for AMD platforms ASoC: SOF: amd: add machine select logic for soundwire based platforms ASoC: SOF: amd: update descriptor fields for acp6.3 based platform ASoC: SOF: amd: select soundwire dependency flag for acp6.3 based platform ASoC: SOF: amd: refactor acp driver pm ops drivers/soundwire/Makefile | 2 +- drivers/soundwire/amd_init.c | 235 +++++++++++++++++++++++++++++ drivers/soundwire/amd_init.h | 13 ++ drivers/soundwire/amd_manager.c | 41 +---- drivers/soundwire/amd_manager.h | 12 +- include/linux/soundwire/sdw_amd.h | 79 ++++++++-- include/sound/sof/dai-amd.h | 7 + include/sound/sof/dai.h | 2 + include/uapi/sound/sof/tokens.h | 4 + sound/soc/amd/acp/Kconfig | 7 + sound/soc/amd/acp/Makefile | 2 + sound/soc/amd/acp/amd-sdw-acpi.c | 62 ++++++++ sound/soc/sof/amd/Kconfig | 18 +++ sound/soc/sof/amd/acp-common.c | 65 +++++++- sound/soc/sof/amd/acp-dsp-offset.h | 10 ++ sound/soc/sof/amd/acp.c | 202 ++++++++++++++++++++++++- sound/soc/sof/amd/acp.h | 26 +++- sound/soc/sof/amd/pci-acp63.c | 7 + sound/soc/sof/ipc3-pcm.c | 25 +++ sound/soc/sof/ipc3-topology.c | 40 +++++ sound/soc/sof/sof-audio.h | 1 + sound/soc/sof/topology.c | 5 + 22 files changed, 798 insertions(+), 67 deletions(-) create mode 100644 drivers/soundwire/amd_init.c create mode 100644 drivers/soundwire/amd_init.h create mode 100644 sound/soc/amd/acp/amd-sdw-acpi.c