| Message ID | 3852ff28ea7d5d8f2086d8dd78aeff8d1d984991.1704748435.git.soyer@irl.hu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dcaca1b5f0d47f4ed59f606795df531cc8a2d7d2 |
| Headers | show |
| Series | ALSA: hda/tas2781: annotate calibration data endianness | expand |
On Mon, 08 Jan 2024 22:16:46 +0100, Gergo Koteles wrote: > > Sparse reports an endian mismatch. > The amplifier expects the calibration data as big-endian. > Use the __be32 type to express endianness better. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/ > > Signed-off-by: Gergo Koteles <soyer@irl.hu> Thanks, applied with the additional Fixes tag to the commit. Takashi
diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c index 4805cf0b6480..2dd809de62e5 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -424,8 +424,8 @@ static const struct snd_kcontrol_new tas2781_dsp_conf_ctrl = { static void tas2563_apply_calib(struct tasdevice_priv *tas_priv) { - unsigned int data; int offset = 0; + __be32 data; int ret; for (int i = 0; i < tas_priv->ndev; i++) {
Sparse reports an endian mismatch. The amplifier expects the calibration data as big-endian. Use the __be32 type to express endianness better. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401072137.Oc7pQgRW-lkp@intel.com/ Signed-off-by: Gergo Koteles <soyer@irl.hu> --- sound/pci/hda/tas2781_hda_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 736c40609d31481b3b2fffe8c239f2c86fb2b54c