| Message ID | 20240109140437.3703330-1-tudor.ambarus@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: irq: include <linux/cpumask.h> | expand |
On Tue, Jan 09, 2024 at 02:04:37PM +0000, Tudor Ambarus wrote: > Sorting include files in alphabetic order in > drivers/tty/serial/samsung.c revealed the following error: > > In file included from drivers/tty/serial/samsung_tty.c:24: > ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name 'cpumask_t' > 9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); > | ^~~~~~~~~ > > Include cpumask.h to avod unknown type errors for parents of irq.h that > don't include cpumask.h. s/avod/avoid/ > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > arch/arm64/include/asm/irq.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h > index 50ce8b697ff3..d5612bc770da 100644 > --- a/arch/arm64/include/asm/irq.h > +++ b/arch/arm64/include/asm/irq.h > @@ -5,6 +5,7 @@ > #ifndef __ASSEMBLER__ > > #include <asm-generic/irq.h> > +#include <linux/cpumask.h> Minor nit: we usually have the <linux/*.h> headers first, then a line space, then the <asm/*.h> headers, e.g. | #include <linux/cpumask.h> | | #include <asm-generic/irq.h> With those changes, the patch itself looks good to me: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); > #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace > -- > 2.43.0.472.g3155946c3a-goog >
On 1/9/24 14:46, Mark Rutland wrote: > On Tue, Jan 09, 2024 at 02:04:37PM +0000, Tudor Ambarus wrote: >> Sorting include files in alphabetic order in >> drivers/tty/serial/samsung.c revealed the following error: >> >> In file included from drivers/tty/serial/samsung_tty.c:24: >> ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name 'cpumask_t' >> 9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); >> | ^~~~~~~~~ >> >> Include cpumask.h to avod unknown type errors for parents of irq.h that >> don't include cpumask.h. > > s/avod/avoid/ ah, will fix, thanks. > >> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> >> --- >> arch/arm64/include/asm/irq.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h >> index 50ce8b697ff3..d5612bc770da 100644 >> --- a/arch/arm64/include/asm/irq.h >> +++ b/arch/arm64/include/asm/irq.h >> @@ -5,6 +5,7 @@ >> #ifndef __ASSEMBLER__ >> >> #include <asm-generic/irq.h> >> +#include <linux/cpumask.h> > > Minor nit: we usually have the <linux/*.h> headers first, then a line space, > then the <asm/*.h> headers, e.g. I wasn't aware of this habit. Will update accordingly in v2. Thanks! ta
diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h index 50ce8b697ff3..d5612bc770da 100644 --- a/arch/arm64/include/asm/irq.h +++ b/arch/arm64/include/asm/irq.h @@ -5,6 +5,7 @@ #ifndef __ASSEMBLER__ #include <asm-generic/irq.h> +#include <linux/cpumask.h> void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace
Sorting include files in alphabetic order in drivers/tty/serial/samsung.c revealed the following error: In file included from drivers/tty/serial/samsung_tty.c:24: ./arch/arm64/include/asm/irq.h:9:43: error: unknown type name ‘cpumask_t’ 9 | void arch_trigger_cpumask_backtrace(const cpumask_t *mask, int exclude_cpu); | ^~~~~~~~~ Include cpumask.h to avod unknown type errors for parents of irq.h that don't include cpumask.h. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- arch/arm64/include/asm/irq.h | 1 + 1 file changed, 1 insertion(+)