| Message ID | 20240108181610.2697017-8-leitao@debian.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fix MODULE_DESCRIPTION() for net (p1) | expand |
Hi, On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote: > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to IPv6 over Low power Wireless Personal Area Network. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > net/6lowpan/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c > index 7b3341cef926..80d83151ef29 100644 > --- a/net/6lowpan/core.c > +++ b/net/6lowpan/core.c > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void) > > module_init(lowpan_module_init); > module_exit(lowpan_module_exit); > - > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module"); Here is a nitpick as well. The correct acronym [0] is "IPv6 over Low-Power Wireless Personal Area Network", otherwise it is okay. Acked-by: Alexander Aring <aahringo@redhat.com> - Alex
Hi, On Tue, Jan 9, 2024 at 8:04 PM Alexander Aring <aahringo@redhat.com> wrote: > > Hi, > > On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote: > > > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > Add descriptions to IPv6 over Low power Wireless Personal Area Network. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > --- > > net/6lowpan/core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c > > index 7b3341cef926..80d83151ef29 100644 > > --- a/net/6lowpan/core.c > > +++ b/net/6lowpan/core.c > > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void) > > > > module_init(lowpan_module_init); > > module_exit(lowpan_module_exit); > > - > > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module"); > > Here is a nitpick as well. The correct acronym [0] is "IPv6 over > Low-Power Wireless Personal Area Network", otherwise it is okay. > > Acked-by: Alexander Aring <aahringo@redhat.com> > > - Alex [0] https://datatracker.ietf.org/wg/6lowpan/about/
On Tue, Jan 09, 2024 at 08:04:47PM -0500, Alexander Aring wrote: > Hi, > > On Mon, Jan 8, 2024 at 1:21 PM Breno Leitao <leitao@debian.org> wrote: > > > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > Add descriptions to IPv6 over Low power Wireless Personal Area Network. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > --- > > net/6lowpan/core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c > > index 7b3341cef926..80d83151ef29 100644 > > --- a/net/6lowpan/core.c > > +++ b/net/6lowpan/core.c > > @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void) > > > > module_init(lowpan_module_init); > > module_exit(lowpan_module_exit); > > - > > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module"); > > Here is a nitpick as well. The correct acronym [0] is "IPv6 over > Low-Power Wireless Personal Area Network", otherwise it is okay. Thanks. I will update.
diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c index 7b3341cef926..80d83151ef29 100644 --- a/net/6lowpan/core.c +++ b/net/6lowpan/core.c @@ -178,5 +178,5 @@ static void __exit lowpan_module_exit(void) module_init(lowpan_module_init); module_exit(lowpan_module_exit); - +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network module"); MODULE_LICENSE("GPL");
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to IPv6 over Low power Wireless Personal Area Network. Signed-off-by: Breno Leitao <leitao@debian.org> --- net/6lowpan/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)