| Message ID | 20240110201216.18016-17-avromanov@salutedevices.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | Support more Amlogic SoC families in crypto driver | expand |
On Wed, 10 Jan 2024 23:11:32 +0300, Alexey Romanov wrote: > Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > .../devicetree/bindings/crypto/amlogic,gxl-crypto.yaml | 2 ++ > 1 file changed, 2 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.example.dtb: crypto-engine@c883e000: compatible: ['amlogic,gxl-crypto'] is too short from schema $id: http://devicetree.org/schemas/crypto/amlogic,gxl-crypto.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240110201216.18016-17-avromanov@salutedevices.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Jan 10, 2024 at 11:11:32PM +0300, Alexey Romanov wrote: > Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > .../devicetree/bindings/crypto/amlogic,gxl-crypto.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > index 948e11ebe4ee..317003505510 100644 > --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > @@ -13,6 +13,8 @@ properties: > compatible: > items: > - const: amlogic,gxl-crypto > + - const: amlogic,g12a-crypto > + - const: amlogic,axg-crypto You need an 'enum'. > > reg: > maxItems: 1 > -- > 2.30.1 >
Hi, On 10/01/2024 21:11, Alexey Romanov wrote: > Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG. > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > .../devicetree/bindings/crypto/amlogic,gxl-crypto.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > index 948e11ebe4ee..317003505510 100644 > --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > @@ -13,6 +13,8 @@ properties: > compatible: > items: > - const: amlogic,gxl-crypto > + - const: amlogic,g12a-crypto > + - const: amlogic,axg-crypto Please add amlogic,s4-crypto and amlogic,a1-crypto using amlogic,g12a-crypto as fallback, it's a requirement for dt bindings to have per-soc compatibles now. Thanks, Neil > > reg: > maxItems: 1
diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml index 948e11ebe4ee..317003505510 100644 --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml @@ -13,6 +13,8 @@ properties: compatible: items: - const: amlogic,gxl-crypto + - const: amlogic,g12a-crypto + - const: amlogic,axg-crypto reg: maxItems: 1
Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG. Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> --- .../devicetree/bindings/crypto/amlogic,gxl-crypto.yaml | 2 ++ 1 file changed, 2 insertions(+)