| Message ID | 20240109004728.54703-1-yang.lee@linux.alibaba.com |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] cxl: Remove duplicated include in cdat.c | expand |
On Tue, 9 Jan 2024 08:47:28 +0800 Yang Li <yang.lee@linux.alibaba.com> wrote: > The header files core.h is included twice in cdat.c, > so one inclusion can be removed. > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Obviously correct :) Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/cxl/core/cdat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c > index f5e649407b8b..6fe11546889f 100644 > --- a/drivers/cxl/core/cdat.c > +++ b/drivers/cxl/core/cdat.c > @@ -9,7 +9,6 @@ > #include "cxlmem.h" > #include "core.h" > #include "cxl.h" > -#include "core.h" > > struct dsmas_entry { > struct range dpa_range;
On 1/8/24 17:47, Yang Li wrote: > The header files core.h is included twice in cdat.c, > so one inclusion can be removed. > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/cxl/core/cdat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c > index f5e649407b8b..6fe11546889f 100644 > --- a/drivers/cxl/core/cdat.c > +++ b/drivers/cxl/core/cdat.c > @@ -9,7 +9,6 @@ > #include "cxlmem.h" > #include "core.h" > #include "cxl.h" > -#include "core.h" > > struct dsmas_entry { > struct range dpa_range;
Yang Li wrote: > The header files core.h is included twice in cdat.c, > so one inclusion can be removed. > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/cxl/core/cdat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c > index f5e649407b8b..6fe11546889f 100644 > --- a/drivers/cxl/core/cdat.c > +++ b/drivers/cxl/core/cdat.c > @@ -9,7 +9,6 @@ > #include "cxlmem.h" > #include "core.h" > #include "cxl.h" > -#include "core.h" I believe that was due to a bad merge by me. That's fixed up now with a better merge commit. Thanks for spotting this though!
diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c index f5e649407b8b..6fe11546889f 100644 --- a/drivers/cxl/core/cdat.c +++ b/drivers/cxl/core/cdat.c @@ -9,7 +9,6 @@ #include "cxlmem.h" #include "core.h" #include "cxl.h" -#include "core.h" struct dsmas_entry { struct range dpa_range;
The header files core.h is included twice in cdat.c, so one inclusion can be removed. Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/cxl/core/cdat.c | 1 - 1 file changed, 1 deletion(-)