| Message ID | 20240111072018.75971-1-chentao@kylinos.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 776dac5a662774f07a876b650ba578d0a62d20db |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe | expand |
On Thu, Jan 11, 2024 at 03:20:18PM +0800, Kunwu Chan wrote: > devm_kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. > > Cc: Kunwu Chan <kunwu.chan@hotmail.com> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> > Suggested-by: Jakub Kicinski <kuba@kernel.org> Hi Kunwu, This seems to be a bug fix. If so it should have a fixes tag. Perhaps this one is correct? Fixes: 05bd97fc559d ("net: dsa: Add Vitesse VSC73xx DSA router driver") And, be targeted against net (as opposed to net-next) Subject: [PATCH net v2] ... It is probably not necessary to repost to address these minor issues, but please keep this in mind in future. The above notwithstanding, Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 11 Jan 2024 15:20:18 +0800 you wrote: > devm_kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. > > Cc: Kunwu Chan <kunwu.chan@hotmail.com> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> > Suggested-by: Jakub Kicinski <kuba@kernel.org> > > [...] Here is the summary with links: - [v2] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe https://git.kernel.org/netdev/net/c/776dac5a6627 You are awesome, thank you!
diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c index e6f29e4e508c..571f037fe649 100644 --- a/drivers/net/dsa/vitesse-vsc73xx-core.c +++ b/drivers/net/dsa/vitesse-vsc73xx-core.c @@ -1135,6 +1135,8 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc) vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x", vsc->chipid); + if (!vsc->gc.label) + return -ENOMEM; vsc->gc.ngpio = 4; vsc->gc.owner = THIS_MODULE; vsc->gc.parent = vsc->dev;
devm_kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Cc: Kunwu Chan <kunwu.chan@hotmail.com> Signed-off-by: Kunwu Chan <chentao@kylinos.cn> Suggested-by: Jakub Kicinski <kuba@kernel.org> --- v2: Remove error print --- drivers/net/dsa/vitesse-vsc73xx-core.c | 2 ++ 1 file changed, 2 insertions(+)