diff mbox series

[net,2/2] selftests: forwarding: Remove executable bits from lib.sh

Message ID 20240110141436.157419-3-bpoirier@nvidia.com (mailing list archive)
State Accepted
Commit 66cee759ffa3d1146a22182c3d5a6404c7cfe9fd
Delegated to: Netdev Maintainers
Headers show
Series selftests: net: Small fixes | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net
netdev/ynl success SINGLE THREAD; Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success net selftest script(s) already in Makefile
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 0 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest pending net-next-2024-01-16--06-00

Commit Message

Benjamin Poirier Jan. 10, 2024, 2:14 p.m. UTC 
The lib.sh script is meant to be sourced from other scripts, not executed
directly. Therefore, remove the executable bits from lib.sh's permissions.

Fixes: fe32dffdcd33 ("selftests: forwarding: add TCPDUMP_EXTRA_FLAGS to lib.sh")
Tested-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
---
 tools/testing/selftests/net/forwarding/lib.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 tools/testing/selftests/net/forwarding/lib.sh

Comments

Paolo Abeni Jan. 16, 2024, 8:32 a.m. UTC | #1 
On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote:
> The lib.sh script is meant to be sourced from other scripts, not executed
> directly. Therefore, remove the executable bits from lib.sh's permissions.

LGTM, but there is any special reason to not fix the permissions of
other *lib.sh files in the same directory? Could be a follow-up.

Thanks!

Paolo
Benjamin Poirier Jan. 19, 2024, 9:56 p.m. UTC | #2 
On 2024-01-16 09:32 +0100, Paolo Abeni wrote:
> On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote:
> > The lib.sh script is meant to be sourced from other scripts, not executed
> > directly. Therefore, remove the executable bits from lib.sh's permissions.
> 
> LGTM, but there is any special reason to not fix the permissions of
> other *lib.sh files in the same directory? Could be a follow-up.

I just looked into it and as of dbc153fd3c14 other *lib.sh files under
tools/testing/selftests/net/forwarding/ do not have any executable bits.
Did I miss something?

tools/testing/selftests/net/setup_loopback.sh has an unneccessary +x,
I'll send a patch for that one.
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
old mode 100755
new mode 100644