| Message ID | 20240118031929.192192-1-chentao@kylinos.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6e2276203ac9ff10fc76917ec9813c660f627369 |
| Headers | show |
| Series | dmaengine: ti: edma: Add some null pointer checks to the edma_probe | expand |
On Thu, 18 Jan 2024 11:19:29 +0800, Kunwu Chan wrote: > devm_kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. Ensure the allocation was successful > by checking the pointer validity. > > Applied, thanks! [1/1] dmaengine: ti: edma: Add some null pointer checks to the edma_probe commit: 6e2276203ac9ff10fc76917ec9813c660f627369 Best regards,
diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c index f1f920861fa9..5f8d2e93ff3f 100644 --- a/drivers/dma/ti/edma.c +++ b/drivers/dma/ti/edma.c @@ -2404,6 +2404,11 @@ static int edma_probe(struct platform_device *pdev) if (irq > 0) { irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint", dev_name(dev)); + if (!irq_name) { + ret = -ENOMEM; + goto err_disable_pm; + } + ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name, ecc); if (ret) { @@ -2420,6 +2425,11 @@ static int edma_probe(struct platform_device *pdev) if (irq > 0) { irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint", dev_name(dev)); + if (!irq_name) { + ret = -ENOMEM; + goto err_disable_pm; + } + ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name, ecc); if (ret) {
devm_kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Ensure the allocation was successful by checking the pointer validity. Signed-off-by: Kunwu Chan <chentao@kylinos.cn> --- drivers/dma/ti/edma.c | 10 ++++++++++ 1 file changed, 10 insertions(+)