[v2,0/8] Improve SOF support for Steam Deck OLED

Message

Cristian Ciocaltea Dec. 19, 2023, 3:07 a.m. UTC

This patch series is a continuation of [1] to provide several fixes and
improvements to the SOF drivers targeting the Vangogh platform, as found on
Valve's Steam Deck OLED.  The previous series only handled the legacy ACP
drivers.

Also note that, since v2, this patch series requires an updated SOF
topology to provide a correct DAI link ID for the BT codec.  The binary
file should be located under:

  /usr/lib/firmware/amd/sof-tplg/sof-vangogh-nau8821-max.tplg

Alternatively, as a temporary workaround, patch [2] can be used to adapt
the driver to the broken topology.

Another requirement to get this functional is patch [3] from v1, which has
been dropped from the series to be upstreamed via the SOF development
workflow.

[1]: https://lore.kernel.org/all/[e-mail]/
[2]: https://lore.kernel.org/all/[e-mail]/
[3]: https://lore.kernel.org/all/[e-mail]/

Changes in v2:
 - Updated commit message in PATCH 3 according to Emil's review
 - Reworked PATCH 7 according to Péter's suggestion and dropped PATCH 8
   which is obsolete now
 - Dropped incorrect PATCH 10/11, according to Venkata the fw is broken and
   requires update
 - Dropped PATCH 11/11 which is handled via the SOF workflow
 - Added R-b from Emil too all remaining patches, except the reworked one
 - Rebased series onto next-20231218
 - v1:
   https://lore.kernel.org/all/[e-mail]/

Cristian Ciocaltea (8):
  ASoC: amd: acp: Drop redundant initialization of machine driver data
  ASoC: amd: acp: Make use of existing *_CODEC_DAI macros
  ASoC: amd: acp: Add missing error handling in sof-mach
  ASoC: amd: acp: Update MODULE_DESCRIPTION for sof-mach
  ASoC: SOF: amd: Fix memory leak in amd_sof_acp_probe()
  ASoC: SOF: amd: Optimize quirk for Valve Galileo
  ASoC: SOF: core: Skip firmware test for custom loaders
  ASoC: SOF: amd: Compute file paths on firmware load

 sound/soc/amd/acp/acp-mach-common.c |  6 +++---
 sound/soc/amd/acp/acp-sof-mach.c    | 26 +++++++----------------
 sound/soc/sof/amd/acp-loader.c      | 32 +++++++++++++++++++++++------
 sound/soc/sof/amd/acp.c             | 30 ++++++++++++++++-----------
 sound/soc/sof/fw-file-profile.c     | 18 +++++++++++++---
 5 files changed, 69 insertions(+), 43 deletions(-)

Comments

Mark Brown Jan. 22, 2024, 8:44 p.m. UTC | #1

On Tue, 19 Dec 2023 05:07:18 +0200, Cristian Ciocaltea wrote:
> This patch series is a continuation of [1] to provide several fixes and
> improvements to the SOF drivers targeting the Vangogh platform, as found on
> Valve's Steam Deck OLED.  The previous series only handled the legacy ACP
> drivers.
> 
> Also note that, since v2, this patch series requires an updated SOF
> topology to provide a correct DAI link ID for the BT codec.  The binary
> file should be located under:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/8] ASoC: amd: acp: Drop redundant initialization of machine driver data
      commit: f0f1021fc9cb88ebdc241b6121107399ee4f2eb7
[2/8] ASoC: amd: acp: Make use of existing *_CODEC_DAI macros
      commit: 68ab29426d88294d16170919a6a6e764f375113f
[3/8] ASoC: amd: acp: Add missing error handling in sof-mach
      commit: d0ada20279db2649a7549a2b8a4a3379c59f238d
[4/8] ASoC: amd: acp: Update MODULE_DESCRIPTION for sof-mach
      commit: a4832a94688000662d4ebb8a1c05f086a9c98826
[5/8] ASoC: SOF: amd: Fix memory leak in amd_sof_acp_probe()
      commit: 222be59e5eed1554119294edc743ee548c2371d0
[6/8] ASoC: SOF: amd: Optimize quirk for Valve Galileo
      commit: a13f0c3c0e8fb3e61fbfd99c6b350cf9be0c4660
[7/8] ASoC: SOF: core: Skip firmware test for custom loaders
      commit: 369b997a1371aeecd0a1fb0f9f4ef3747a1d07a4
[8/8] ASoC: SOF: amd: Compute file paths on firmware load
      commit: d9cacc1a2af2e1cd781b5cd2a3e57fbde64f5a2d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark