| Message ID | 20240122184543.2501493-10-leitao@debian.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,01/22] net: fill in MODULE_DESCRIPTION()s for 8390 | expand |
> -----Original Message----- > From: Breno Leitao <leitao@debian.org> > Sent: 2024年1月23日 2:46 > To: kuba@kernel.org; davem@davemloft.net; abeni@redhat.com; > edumazet@google.com; Wei Fang <wei.fang@nxp.com>; Shenwei Wang > <shenwei.wang@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>; > dl-linux-imx <linux-imx@nxp.com>; Paolo Abeni <pabeni@redhat.com> > Cc: dsahern@kernel.org; weiwan@google.com; open list:FREESCALE IMX / > MXC FEC DRIVER <netdev@vger.kernel.org>; open list > <linux-kernel@vger.kernel.org> > Subject: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to the FEC (MPC8xx) Ethernet controller. > > Signed-off-by: Breno Leitao <leitao@debian.org> > --- > drivers/net/ethernet/freescale/fec_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index d42594f32275..c56807b757dc 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = { > > module_platform_driver(fec_driver); > > +MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet > driver"); Thank you very much for this patch. It would be better if you change the description to " NXP Fast Ethernet Controller (FEC) driver". > MODULE_LICENSE("GPL"); > -- > 2.39.3
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index d42594f32275..c56807b757dc 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = { module_platform_driver(fec_driver); +MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet driver"); MODULE_LICENSE("GPL");
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the FEC (MPC8xx) Ethernet controller. Signed-off-by: Breno Leitao <leitao@debian.org> --- drivers/net/ethernet/freescale/fec_main.c | 1 + 1 file changed, 1 insertion(+)