Message ID | tencent_B0B3D2BD9861FD009E03AB18A81783322709@qq.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | [v3] eventfd: move 'eventfd-count' printing out of spinlock | expand |
On Mon, 15 Jan 2024 23:27:00 +0800, wenyang.linux@foxmail.com wrote: > When printing eventfd->count, interrupts will be disabled and a spinlock > will be obtained, competing with eventfd_write(). By moving the > "eventfd-count" print out of the spinlock and merging multiple > seq_printf() into one, it could improve a bit, just like timerfd_show(). > > Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] eventfd: move 'eventfd-count' printing out of spinlock https://git.kernel.org/vfs/vfs/c/294a229020f1
diff --git a/fs/eventfd.c b/fs/eventfd.c index ad8186d47ba7..a6fa6ee748df 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -283,13 +283,18 @@ static ssize_t eventfd_write(struct file *file, const char __user *buf, size_t c static void eventfd_show_fdinfo(struct seq_file *m, struct file *f) { struct eventfd_ctx *ctx = f->private_data; + unsigned long long cnt; spin_lock_irq(&ctx->wqh.lock); - seq_printf(m, "eventfd-count: %16llx\n", - (unsigned long long)ctx->count); + cnt = ctx->count; spin_unlock_irq(&ctx->wqh.lock); - seq_printf(m, "eventfd-id: %d\n", ctx->id); - seq_printf(m, "eventfd-semaphore: %d\n", + + seq_printf(m, + "eventfd-count: %16llx\n" + "eventfd-id: %d\n" + "eventfd-semaphore: %d\n", + cnt, + ctx->id, !!(ctx->flags & EFD_SEMAPHORE)); } #endif