mbox series

[0/2,GSoC,RFC/Patch] FIX: use utf8_strnwidth for line_prefix in diff.c

Message ID pull.1653.git.git.1706105064.gitgitgadget@gmail.com (mailing list archive)
Headers show
Series FIX: use utf8_strnwidth for line_prefix in diff.c | expand

Message

Jean-Noël Avila via GitGitGadget Jan. 24, 2024, 2:04 p.m. UTC 
This patch adresses diff.c:2721 and proposes the fix using a new function.

Md Isfarul Haque (2):
  FIX: use utf8_strnwidth for line_prefix in diff.c
  FIX memory leak in one branch

 diff.c | 19 +++++++++++++++++--
 diff.h |  1 +
 2 files changed, 18 insertions(+), 2 deletions(-)


base-commit: e02ecfcc534e2021aae29077a958dd11c3897e4c
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1653%2FInnocentZero%2Fdiff_needswork-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1653/InnocentZero/diff_needswork-v1
Pull-Request: https://github.com/git/git/pull/1653

Comments

Junio C Hamano Jan. 24, 2024, 5:42 p.m. UTC | #1 
"Md Isfarul Haque via GitGitGadget" <gitgitgadget@gmail.com> writes:

> This patch adresses diff.c:2721 and proposes the fix using a new function.

Yay.  My favorite long-time pet-peeve topic.

>
> Md Isfarul Haque (2):
>   FIX: use utf8_strnwidth for line_prefix in diff.c
>   FIX memory leak in one branch

Our convention does not use "FIX" and other prefix on the subject.
Please check Documentation/SubmittingPatches.

Thanks.