[net,0/3] selftests: net: a few fixes

Message

Paolo Abeni Jan. 24, 2024, 9:33 p.m. UTC

This series address self-tests failures for udp gro-related tests.

The first patch addresses the main problem I observe locally - the XDP
program required by such tests, xdp_dummy, is currently build in the
ebpf self-tests directory, not available if/when the user targets net
only. Arguably is more a refactor than a fix, but still targeting net
to hopefully 

The second patch fixes the integration of such tests with the build
system.

Patch 3/3 fixes sporadic failures due to races.

Tested with:

make -C tools/testing/selftests/ TARGETS=net install
./tools/testing/selftests/kselftest_install/run_kselftest.sh \
	-t "net:udpgro_bench.sh net:udpgro.sh net:udpgro_fwd.sh \
	    net:udpgro_frglist.sh net:veth.sh"

no failures.

Paolo Abeni (3):
  selftests: net: remove dependency on ebpf tests
  selftests: net: included needed helper in the install targets
  selftests: net: explicitly wait for listener ready

 tools/testing/selftests/net/Makefile          |  6 ++++--
 tools/testing/selftests/net/udpgro.sh         |  4 ++--
 tools/testing/selftests/net/udpgro_bench.sh   |  4 ++--
 tools/testing/selftests/net/udpgro_frglist.sh |  6 +++---
 tools/testing/selftests/net/udpgro_fwd.sh     |  8 +++++---
 tools/testing/selftests/net/veth.sh           |  4 ++--
 tools/testing/selftests/net/xdp_dummy.c       | 13 +++++++++++++
 7 files changed, 31 insertions(+), 14 deletions(-)
 create mode 100644 tools/testing/selftests/net/xdp_dummy.c

Comments

Jakub Kicinski Jan. 25, 2024, 1:45 a.m. UTC | #1

On Wed, 24 Jan 2024 22:33:19 +0100 Paolo Abeni wrote:
> This series address self-tests failures for udp gro-related tests.
> 
> The first patch addresses the main problem I observe locally - the XDP
> program required by such tests, xdp_dummy, is currently build in the
> ebpf self-tests directory, not available if/when the user targets net
> only. Arguably is more a refactor than a fix, but still targeting net
> to hopefully 
> 
> The second patch fixes the integration of such tests with the build
> system.
> 
> Patch 3/3 fixes sporadic failures due to races.
> 
> Tested with:
> 
> make -C tools/testing/selftests/ TARGETS=net install
> ./tools/testing/selftests/kselftest_install/run_kselftest.sh \
> 	-t "net:udpgro_bench.sh net:udpgro.sh net:udpgro_fwd.sh \
> 	    net:udpgro_frglist.sh net:veth.sh"
> 
> no failures.

This series got into net-next-2024-01-25--00-00, looking at the outputs
it turns out that the iproute2 was crashing somewhere in libbpf :(
I rebuilt latest iproute2 without libbpf support. It loads xdp_dummy.o
just fine, so hopefully that's good enough for now, we'll see for sure
in about 3 hours :)

[e-mail] Jan. 26, 2024, 12:10 a.m. UTC | #2

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Wed, 24 Jan 2024 22:33:19 +0100 you wrote:
> This series address self-tests failures for udp gro-related tests.
> 
> The first patch addresses the main problem I observe locally - the XDP
> program required by such tests, xdp_dummy, is currently build in the
> ebpf self-tests directory, not available if/when the user targets net
> only. Arguably is more a refactor than a fix, but still targeting net
> to hopefully
> 
> [...]

Here is the summary with links:
  - [net,1/3] selftests: net: remove dependency on ebpf tests
    https://git.kernel.org/netdev/net/c/98cb12eb52a7
  - [net,2/3] selftests: net: included needed helper in the install targets
    https://git.kernel.org/netdev/net/c/f5173fe3e13b
  - [net,3/3] selftests: net: explicitly wait for listener ready
    https://git.kernel.org/netdev/net/c/4acffb66630a

You are awesome, thank you!