| Message ID | b807c2a70dba9711376b265b6da5fb5ff14589aa.1706105494.git.esben@geanix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/3] net: stmmac: do not clear TBS enable bit on link up/down | expand |
Hi, On Wed Jan 24 2024, Esben Haabendal wrote: > This allows enabling TBS for TX queues by adding the > snps,time-based-scheduling property. You should check for support for this > on your particular controller before enabling. Typically, TX queue 0 does > not support TBS. More a general question: Do i see that correctly that Launch Time does not work for OF platforms (such as an imx93) at the moment, because the tbs_en property is not configured? Or why are these patches necessary? Thanks, Kurt
Kurt Kanzenbach <kurt.kanzenbach@linutronix.de> writes: > Hi, > > On Wed Jan 24 2024, Esben Haabendal wrote: >> This allows enabling TBS for TX queues by adding the >> snps,time-based-scheduling property. You should check for support for this >> on your particular controller before enabling. Typically, TX queue 0 does >> not support TBS. > > More a general question: Do i see that correctly that Launch Time does > not work for OF platforms (such as an imx93) at the moment, because the > tbs_en property is not configured? Or why are these patches necessary? Correct. You cannot use etf qdisc with "offload" on for OF platforms, including imx93. Doing that will end with "return -EINVAL" in tc_setup_etf(). I am working with imx98mp, but there should not be any difference for imx93. /Esben
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c index 70eadc83ca68..f0bb49b0f41c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c @@ -278,6 +278,8 @@ static int stmmac_mtl_setup(struct platform_device *pdev, plat->tx_queues_cfg[queue].coe_unsupported = of_property_read_bool(q_node, "snps,coe-unsupported"); + plat->tx_queues_cfg[queue].tbs_en = + of_property_read_bool(q_node, "snps,time-based-scheduling"); queue++; }
This allows enabling TBS for TX queues by adding the snps,time-based-scheduling property. You should check for support for this on your particular controller before enabling. Typically, TX queue 0 does not support TBS. Signed-off-by: Esben Haabendal <esben@geanix.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 ++ 1 file changed, 2 insertions(+)