| Message ID | 20231217113208.64056-1-stefan.nagy@ixypsilon.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: rockchip: Increase maximum frequency of SPI flash for ROCK Pi 4A/B/C | expand |
On 2023-12-17 12:32, Stefan Nagy wrote: > The ROCK Pi 4A/B/C boards come with a 32 Mbit SPI NOR flash chip (XTX > Technology Limited XT25F32) with a maximum clock frequency of 108 MHz. > Use this value for the device node's spi-max-frequency property. > > This patch has been tested on ROCK Pi 4A. > > Signed-off-by: Stefan Nagy <stefan.nagy@ixypsilon.net> Looks good to me. It would be nice, if you have time, to include some SPI benchmark results before and after the change in the commit message. Otherwise, Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > Changes from v1: > - Use the maximum clock frequency the SPI chip actually supports > instead of the SPI clock frequency limit of 50 MHz set by the > Rockchip SPI driver. > --- > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts > b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts > index d5df8939a..c68f45849 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts > @@ -19,6 +19,6 @@ &spi1 { > flash@0 { > compatible = "jedec,spi-nor"; > reg = <0>; > - spi-max-frequency = <10000000>; > + spi-max-frequency = <108000000>; > }; > }; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts > b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts > index bee6d7588..6ea3180e5 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts > @@ -37,7 +37,7 @@ &spi1 { > flash@0 { > compatible = "jedec,spi-nor"; > reg = <0>; > - spi-max-frequency = <10000000>; > + spi-max-frequency = <108000000>; > }; > }; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts > b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts > index de2ebe4cb..5274938bf 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts > @@ -49,7 +49,7 @@ &spi1 { > flash@0 { > compatible = "jedec,spi-nor"; > reg = <0>; > - spi-max-frequency = <10000000>; > + spi-max-frequency = <108000000>; > }; > };
On Sun, 17 Dec 2023 12:32:08 +0100, Stefan Nagy wrote: > The ROCK Pi 4A/B/C boards come with a 32 Mbit SPI NOR flash chip (XTX > Technology Limited XT25F32) with a maximum clock frequency of 108 MHz. > Use this value for the device node's spi-max-frequency property. > > This patch has been tested on ROCK Pi 4A. > > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: Increase maximum frequency of SPI flash for ROCK Pi 4A/B/C commit: fa16d7a820e42946c511e331cdd81dde579066b7 Best regards,
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts index d5df8939a..c68f45849 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts @@ -19,6 +19,6 @@ &spi1 { flash@0 { compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <10000000>; + spi-max-frequency = <108000000>; }; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts index bee6d7588..6ea3180e5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts @@ -37,7 +37,7 @@ &spi1 { flash@0 { compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <10000000>; + spi-max-frequency = <108000000>; }; }; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts index de2ebe4cb..5274938bf 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts @@ -49,7 +49,7 @@ &spi1 { flash@0 { compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <10000000>; + spi-max-frequency = <108000000>; }; };
The ROCK Pi 4A/B/C boards come with a 32 Mbit SPI NOR flash chip (XTX Technology Limited XT25F32) with a maximum clock frequency of 108 MHz. Use this value for the device node's spi-max-frequency property. This patch has been tested on ROCK Pi 4A. Signed-off-by: Stefan Nagy <stefan.nagy@ixypsilon.net> --- Changes from v1: - Use the maximum clock frequency the SPI chip actually supports instead of the SPI clock frequency limit of 50 MHz set by the Rockchip SPI driver. --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4a.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)