[net,v2,0/2] nfp: flower: a few small conntrack offload fixes

Message

Louis Peens Jan. 24, 2024, 3:19 p.m. UTC

This small series addresses two bugs in the nfp conntrack offloading
code.

The first patch is a check to prevent offloading for a case which is
currently not supported by the nfp.

The second patch fixes up parsing of layer4 mangling code so it can be
correctly offloaded. Since the masks are an inverse mask and we are
shifting it so it can be packed together with the destination we
effectively need to 'clear' the lower bits of the mask by setting it to
0xFFFF.

Changes since v1:
- Added inline comment to the second patch
- Expanded the commit message to better explain the mask setting in the
  second patch.

Hui Zhou (2):
  nfp: flower: add hardware offload check for post ct entry
  nfp: flower: fix hardware offload for the transfer layer port

 .../ethernet/netronome/nfp/flower/conntrack.c | 46 +++++++++++++++++--
 1 file changed, 43 insertions(+), 3 deletions(-)

Comments

[e-mail] Jan. 26, 2024, 1:20 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Wed, 24 Jan 2024 17:19:07 +0200 you wrote:
> This small series addresses two bugs in the nfp conntrack offloading
> code.
> 
> The first patch is a check to prevent offloading for a case which is
> currently not supported by the nfp.
> 
> The second patch fixes up parsing of layer4 mangling code so it can be
> correctly offloaded. Since the masks are an inverse mask and we are
> shifting it so it can be packed together with the destination we
> effectively need to 'clear' the lower bits of the mask by setting it to
> 0xFFFF.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/2] nfp: flower: add hardware offload check for post ct entry
    https://git.kernel.org/netdev/net/c/cefa98e806fd
  - [net,v2,2/2] nfp: flower: fix hardware offload for the transfer layer port
    https://git.kernel.org/netdev/net/c/3a007b8009b5

You are awesome, thank you!