| Message ID | 20240123200151.60848-1-gerhard@engleder-embedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5f76499fb541c3e8ae401414bfdf702940c8c531 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] tsnep: Add link down PHY loopback support | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 23 Jan 2024 21:01:51 +0100 you wrote: > PHY loopback turns off link state change signalling. Therefore, the > loopback only works if the link is already up before the PHY loopback is > activated. > > Ensure that PHY loopback works even if the link is not already up during > activation by calling netif_carrier_on() explicitly. > > [...] Here is the summary with links: - [net-next] tsnep: Add link down PHY loopback support https://git.kernel.org/netdev/net-next/c/5f76499fb541 You are awesome, thank you!
diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c index df40c720e7b2..0462834cf6e1 100644 --- a/drivers/net/ethernet/engleder/tsnep_main.c +++ b/drivers/net/ethernet/engleder/tsnep_main.c @@ -229,8 +229,10 @@ static int tsnep_phy_loopback(struct tsnep_adapter *adapter, bool enable) * would delay a working loopback anyway, let's ensure that loopback * is working immediately by setting link mode directly */ - if (!retval && enable) + if (!retval && enable) { + netif_carrier_on(adapter->netdev); tsnep_set_link_mode(adapter); + } return retval; }
PHY loopback turns off link state change signalling. Therefore, the loopback only works if the link is already up before the PHY loopback is activated. Ensure that PHY loopback works even if the link is not already up during activation by calling netif_carrier_on() explicitly. Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> --- drivers/net/ethernet/engleder/tsnep_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)