| Message ID | 20240119081107.5306-1-linwenkai6@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: hisilicon - Fix smp_processor_id() warnings | expand |
On Fri, Jan 19, 2024 at 04:11:07PM +0800, Wenkai Lin wrote: > Switch to raw_smp_processor_id() to prevent a number of > warnings from kernel debugging. We do not care about > preemption here, as the CPU number is only used as a > poor mans load balancing or device selection. If preemption > happens during an encrypt/decrypt operation a small performance > hit will occur but everything will continue to work, so just > ignore it. This commit is similar to e7a9b05ca4 > ("crypto: cavium - Fix smp_processor_id() warnings"). > > [ 7538.874350] BUG: using smp_processor_id() in preemptible [00000000] code: af_alg06/8438 > [ 7538.874368] caller is debug_smp_processor_id+0x1c/0x28 > [ 7538.874373] CPU: 50 PID: 8438 Comm: af_alg06 Kdump: loaded Not tainted 5.10.0.pc+ #18 > [ 7538.874377] Call trace: > [ 7538.874387] dump_backtrace+0x0/0x210 > [ 7538.874389] show_stack+0x2c/0x38 > [ 7538.874392] dump_stack+0x110/0x164 > [ 7538.874394] check_preemption_disabled+0xf4/0x108 > [ 7538.874396] debug_smp_processor_id+0x1c/0x28 > [ 7538.874406] sec_create_qps+0x24/0xe8 [hisi_sec2] > [ 7538.874408] sec_ctx_base_init+0x20/0x4d8 [hisi_sec2] > [ 7538.874411] sec_aead_ctx_init+0x68/0x180 [hisi_sec2] > [ 7538.874413] sec_aead_sha256_ctx_init+0x28/0x38 [hisi_sec2] > [ 7538.874421] crypto_aead_init_tfm+0x54/0x68 > [ 7538.874423] crypto_create_tfm_node+0x6c/0x110 > [ 7538.874424] crypto_alloc_tfm_node+0x74/0x288 > [ 7538.874426] crypto_alloc_aead+0x40/0x50 > [ 7538.874431] aead_bind+0x50/0xd0 > [ 7538.874433] alg_bind+0x94/0x148 > [ 7538.874439] __sys_bind+0x98/0x118 > [ 7538.874441] __arm64_sys_bind+0x28/0x38 > [ 7538.874445] do_el0_svc+0x88/0x258 > [ 7538.874447] el0_svc+0x1c/0x28 > [ 7538.874449] el0_sync_handler+0x8c/0xb8 > [ 7538.874452] el0_sync+0x148/0x180 > > Signed-off-by: Wenkai Lin <linwenkai6@hisilicon.com> > --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- > drivers/crypto/hisilicon/sec2/sec_main.c | 2 +- > drivers/crypto/hisilicon/zip/zip_main.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c index 56777099e..340592c6b 100644 --- a/drivers/crypto/hisilicon/hpre/hpre_main.c +++ b/drivers/crypto/hisilicon/hpre/hpre_main.c @@ -472,7 +472,7 @@ static inline int hpre_cluster_core_mask(struct hisi_qm *qm) struct hisi_qp *hpre_create_qp(u8 type) { - int node = cpu_to_node(smp_processor_id()); + int node = cpu_to_node(raw_smp_processor_id()); struct hisi_qp *qp = NULL; int ret; diff --git a/drivers/crypto/hisilicon/sec2/sec_main.c b/drivers/crypto/hisilicon/sec2/sec_main.c index 0e56a47eb..eaf3fc6d8 100644 --- a/drivers/crypto/hisilicon/sec2/sec_main.c +++ b/drivers/crypto/hisilicon/sec2/sec_main.c @@ -373,7 +373,7 @@ void sec_destroy_qps(struct hisi_qp **qps, int qp_num) struct hisi_qp **sec_create_qps(void) { - int node = cpu_to_node(smp_processor_id()); + int node = cpu_to_node(raw_smp_processor_id()); u32 ctx_num = ctx_q_num; struct hisi_qp **qps; int ret; diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c index db4c964cd..9e35d6432 100644 --- a/drivers/crypto/hisilicon/zip/zip_main.c +++ b/drivers/crypto/hisilicon/zip/zip_main.c @@ -401,7 +401,7 @@ MODULE_DEVICE_TABLE(pci, hisi_zip_dev_ids); int zip_create_qps(struct hisi_qp **qps, int qp_num, int node) { if (node == NUMA_NO_NODE) - node = cpu_to_node(smp_processor_id()); + node = cpu_to_node(raw_smp_processor_id()); return hisi_qm_alloc_qps_node(&zip_devices, qp_num, 0, node, qps); }
Switch to raw_smp_processor_id() to prevent a number of warnings from kernel debugging. We do not care about preemption here, as the CPU number is only used as a poor mans load balancing or device selection. If preemption happens during an encrypt/decrypt operation a small performance hit will occur but everything will continue to work, so just ignore it. This commit is similar to e7a9b05ca4 ("crypto: cavium - Fix smp_processor_id() warnings"). [ 7538.874350] BUG: using smp_processor_id() in preemptible [00000000] code: af_alg06/8438 [ 7538.874368] caller is debug_smp_processor_id+0x1c/0x28 [ 7538.874373] CPU: 50 PID: 8438 Comm: af_alg06 Kdump: loaded Not tainted 5.10.0.pc+ #18 [ 7538.874377] Call trace: [ 7538.874387] dump_backtrace+0x0/0x210 [ 7538.874389] show_stack+0x2c/0x38 [ 7538.874392] dump_stack+0x110/0x164 [ 7538.874394] check_preemption_disabled+0xf4/0x108 [ 7538.874396] debug_smp_processor_id+0x1c/0x28 [ 7538.874406] sec_create_qps+0x24/0xe8 [hisi_sec2] [ 7538.874408] sec_ctx_base_init+0x20/0x4d8 [hisi_sec2] [ 7538.874411] sec_aead_ctx_init+0x68/0x180 [hisi_sec2] [ 7538.874413] sec_aead_sha256_ctx_init+0x28/0x38 [hisi_sec2] [ 7538.874421] crypto_aead_init_tfm+0x54/0x68 [ 7538.874423] crypto_create_tfm_node+0x6c/0x110 [ 7538.874424] crypto_alloc_tfm_node+0x74/0x288 [ 7538.874426] crypto_alloc_aead+0x40/0x50 [ 7538.874431] aead_bind+0x50/0xd0 [ 7538.874433] alg_bind+0x94/0x148 [ 7538.874439] __sys_bind+0x98/0x118 [ 7538.874441] __arm64_sys_bind+0x28/0x38 [ 7538.874445] do_el0_svc+0x88/0x258 [ 7538.874447] el0_svc+0x1c/0x28 [ 7538.874449] el0_sync_handler+0x8c/0xb8 [ 7538.874452] el0_sync+0x148/0x180 Signed-off-by: Wenkai Lin <linwenkai6@hisilicon.com> --- drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- drivers/crypto/hisilicon/sec2/sec_main.c | 2 +- drivers/crypto/hisilicon/zip/zip_main.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)