| Message ID | 20240103164734.1151290-1-iskander.amara@theobroma-systems.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck | expand |
Hi Iskander, Am Montag, 22. Januar 2024, 13:17:50 CET schrieb Iskander Amara: > Dear Ladies and Gentlemen, > Is there any feedback about the patch below that you would like to share? no feedback, change looks good. I was mainly waiting for the merge-window to close, so that I can get a nice 6.8-rc1 as base :-) Heiko > ________________________________ > From: Iskander Amara <iskander.amara@theobroma-systems.com> > Sent: Wednesday, January 3, 2024 5:47 PM > To: robh+dt@kernel.org <robh+dt@kernel.org>; krzysztof.kozlowski+dt@linaro.org <krzysztof.kozlowski+dt@linaro.org>; conor+dt@kernel.org <conor+dt@kernel.org>; heiko@sntech.de <heiko@sntech.de>; devicetree@vger.kernel.org <devicetree@vger.kernel.org>; linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>; linux-rockchip@lists.infradead.org <linux-rockchip@lists.infradead.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> > Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>; Iskander Amara <iskander.amara@theobroma-systems.com> > Subject: [PATCH v2] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck > > Two pmuio domains on ringneck are not defined: > 1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809) > 2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809) > > The reason why no functional effect was observed is because of that > the above mentionned PMUIO domains were supplied by a regulator > which is always on. > > So let's add their definition in the dtsi. > > Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com> > --- > v2: > - Fix indentation > arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi > index 12397755830b..bb1aea82e666 100644 > --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi > @@ -347,6 +347,12 @@ pmic_int: pmic-int { > }; > }; > > +&pmu_io_domains { > + pmuio1-supply = <&vcc_3v3>; > + pmuio2-supply = <&vcc_3v3>; > + status = "okay"; > +}; > + > &saradc { > vref-supply = <&vcc_1v8>; > status = "okay"; > -- > 2.34.1 > >
On Wed, 3 Jan 2024 17:47:34 +0100, Iskander Amara wrote: > Two pmuio domains on ringneck are not defined: > 1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809) > 2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809) > > The reason why no functional effect was observed is because of that > the above mentionned PMUIO domains were supplied by a regulator > which is always on. > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: add missing definition of pmu io domains 1 and 2 on ringneck commit: 16a9c74012c4e4bff6d493832cd648b486046ce1 Best regards,
Great, Thank you!
diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi index 12397755830b..bb1aea82e666 100644 --- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi @@ -347,6 +347,12 @@ pmic_int: pmic-int { }; }; +&pmu_io_domains { + pmuio1-supply = <&vcc_3v3>; + pmuio2-supply = <&vcc_3v3>; + status = "okay"; +}; + &saradc { vref-supply = <&vcc_1v8>; status = "okay";
Two pmuio domains on ringneck are not defined: 1- PMUIO1: supplied by vcc_3v3 regulator(PMIC RK809) 2- PMUIO2: supplied by vcc_3v3 regulator(PMIC RK809) The reason why no functional effect was observed is because of that the above mentionned PMUIO domains were supplied by a regulator which is always on. So let's add their definition in the dtsi. Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com> --- v2: - Fix indentation arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)