| Message ID | AS1PR03MB81893D69344708C98EE2B470827F2@AS1PR03MB8189.eurprd03.prod.outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: sfp: add quirk for ODI DFP-34X-2C2 GPON ONU SFP | expand |
Oh, a second repost. What's different from the first repost? On Sun, Jan 28, 2024 at 03:23:06PM +0100, Sergio Palumbo wrote: > DFP-34X-2C2 is a GPON spf module working at both 1000baseX > and 2500baseX. > Setting the module to LAN_SDS_MODE=6 the module is working > at 2500baseX with auto negotiation see at > https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/ > Unfortunatly the module's PHY is accessible at 1000baseX only. > ethtool returning: > Supported ports: [ Fibre ] > Supported link modes: 1000baseX/Full > > After applying the quirk: > Supported ports: [ Fibre ] > Supported link modes: 1000baseX/Full > 2500baseX/Full > Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137 > Tested on sfp to ethernet Media Converter. > Autonegotiating 1000baseX or 2500baseX according to the > connected host speed. > > This module is existing in 2 versions: > Vendor = "ODI" > Vendor = "OEM" > This is the patch for vendor "ODI" > > Patch has been inserted keeping the list in alphabetical order > first by vendor first and then by part string. > > Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it> > --- > drivers/net/phy/sfp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > index 3c0028a4af92..410375bc6b94 100644 > --- a/drivers/net/phy/sfp.c > +++ b/drivers/net/phy/sfp.c > @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { > // 2500MBd NRZ in their EEPROM > SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), > > + // ODI DFP-34X-2C2 GPON ONU support 2500base-X > + SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex), > + > SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), > > // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the > -- > 2.34.1 > >
Hello Russell, this is the pach for the vendor "ODI". Same hardware but different vendor. I explained it in the description. Hope this clarifies. Thanks and regards Sergio Palumbo Il 28/01/2024 15:43, Russell King (Oracle) ha scritto: > Oh, a second repost. What's different from the first repost? > > On Sun, Jan 28, 2024 at 03:23:06PM +0100, Sergio Palumbo wrote: >> DFP-34X-2C2 is a GPON spf module working at both 1000baseX >> and 2500baseX. >> Setting the module to LAN_SDS_MODE=6 the module is working >> at 2500baseX with auto negotiation see at >> https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/ >> Unfortunatly the module's PHY is accessible at 1000baseX only. >> ethtool returning: >> Supported ports: [ Fibre ] >> Supported link modes: 1000baseX/Full >> >> After applying the quirk: >> Supported ports: [ Fibre ] >> Supported link modes: 1000baseX/Full >> 2500baseX/Full >> Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137 >> Tested on sfp to ethernet Media Converter. >> Autonegotiating 1000baseX or 2500baseX according to the >> connected host speed. >> >> This module is existing in 2 versions: >> Vendor = "ODI" >> Vendor = "OEM" >> This is the patch for vendor "ODI" >> >> Patch has been inserted keeping the list in alphabetical order >> first by vendor first and then by part string. >> >> Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it> >> --- >> drivers/net/phy/sfp.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c >> index 3c0028a4af92..410375bc6b94 100644 >> --- a/drivers/net/phy/sfp.c >> +++ b/drivers/net/phy/sfp.c >> @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { >> // 2500MBd NRZ in their EEPROM >> SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), >> >> + // ODI DFP-34X-2C2 GPON ONU support 2500base-X >> + SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex), >> + >> SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), >> >> // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the >> -- >> 2.34.1 >> >>
All the concerns with the OEM version of this patch apply to this one as well. On Fri, Feb 02, 2024 at 06:44:32PM +0100, Sergio Palumbo wrote: > Hello Russell, > this is the pach for the vendor "ODI". > Same hardware but different vendor. > I explained it in the description. > Hope this clarifies. > > Thanks and regards > > Sergio Palumbo > > Il 28/01/2024 15:43, Russell King (Oracle) ha scritto: > > Oh, a second repost. What's different from the first repost? > > > > On Sun, Jan 28, 2024 at 03:23:06PM +0100, Sergio Palumbo wrote: > > > DFP-34X-2C2 is a GPON spf module working at both 1000baseX > > > and 2500baseX. > > > Setting the module to LAN_SDS_MODE=6 the module is working > > > at 2500baseX with auto negotiation see at > > > https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/ > > > Unfortunatly the module's PHY is accessible at 1000baseX only. > > > ethtool returning: > > > Supported ports: [ Fibre ] > > > Supported link modes: 1000baseX/Full > > > > > > After applying the quirk: > > > Supported ports: [ Fibre ] > > > Supported link modes: 1000baseX/Full > > > 2500baseX/Full > > > Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137 > > > Tested on sfp to ethernet Media Converter. > > > Autonegotiating 1000baseX or 2500baseX according to the > > > connected host speed. > > > > > > This module is existing in 2 versions: > > > Vendor = "ODI" > > > Vendor = "OEM" > > > This is the patch for vendor "ODI" > > > > > > Patch has been inserted keeping the list in alphabetical order > > > first by vendor first and then by part string. > > > > > > Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it> > > > --- > > > drivers/net/phy/sfp.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c > > > index 3c0028a4af92..410375bc6b94 100644 > > > --- a/drivers/net/phy/sfp.c > > > +++ b/drivers/net/phy/sfp.c > > > @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { > > > // 2500MBd NRZ in their EEPROM > > > SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), > > > + // ODI DFP-34X-2C2 GPON ONU support 2500base-X > > > + SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex), > > > + > > > SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), > > > // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the > > > -- > > > 2.34.1 > > > > > > > >
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 3c0028a4af92..410375bc6b94 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -495,6 +495,9 @@ static const struct sfp_quirk sfp_quirks[] = { // 2500MBd NRZ in their EEPROM SFP_QUIRK_M("Lantech", "8330-262D-E", sfp_quirk_2500basex), + // ODI DFP-34X-2C2 GPON ONU support 2500base-X + SFP_QUIRK_M("ODI", "DFP-34X-2C2", sfp_quirk_2500basex), + SFP_QUIRK_M("UBNT", "UF-INSTANT", sfp_quirk_ubnt_uf_instant), // Walsun HXSX-ATR[CI]-1 don't identify as copper, and use the
DFP-34X-2C2 is a GPON spf module working at both 1000baseX and 2500baseX. Setting the module to LAN_SDS_MODE=6 the module is working at 2500baseX with auto negotiation see at https://hack-gpon.org/ont-odi-realtek-dfp-34x-2c2/ Unfortunatly the module's PHY is accessible at 1000baseX only. ethtool returning: Supported ports: [ Fibre ] Supported link modes: 1000baseX/Full After applying the quirk: Supported ports: [ Fibre ] Supported link modes: 1000baseX/Full 2500baseX/Full Tested on BANANA PI R3 in OpenWRT v 23.05.2 Kernel 5.15.137 Tested on sfp to ethernet Media Converter. Autonegotiating 1000baseX or 2500baseX according to the connected host speed. This module is existing in 2 versions: Vendor = "ODI" Vendor = "OEM" This is the patch for vendor "ODI" Patch has been inserted keeping the list in alphabetical order first by vendor first and then by part string. Signed-off-by: Sergio Palumbo <palumbo.ser@outlook.it> --- drivers/net/phy/sfp.c | 3 +++ 1 file changed, 3 insertions(+)