| Message ID | 20240119090502.3869695-1-li.meng@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | amd-pstate preferred core | expand |
On Fri, Jan 19, 2024 at 10:05 AM Meng Li <li.meng@amd.com> wrote: > > Hi all: > > The core frequency is subjected to the process variation in semiconductors. > Not all cores are able to reach the maximum frequency respecting the > infrastructure limits. Consequently, AMD has redefined the concept of > maximum frequency of a part. This means that a fraction of cores can reach > maximum frequency. To find the best process scheduling policy for a given > scenario, OS needs to know the core ordering informed by the platform through > highest performance capability register of the CPPC interface. > > Earlier implementations of amd-pstate preferred core only support a static > core ranking and targeted performance. Now it has the ability to dynamically > change the preferred core based on the workload and platform conditions and > accounting for thermals and aging. > > Amd-pstate driver utilizes the functions and data structures provided by > the ITMT architecture to enable the scheduler to favor scheduling on cores > which can be get a higher frequency with lower voltage. > We call it amd-pstate preferred core. > > Here sched_set_itmt_core_prio() is called to set priorities and > sched_set_itmt_support() is called to enable ITMT feature. > Amd-pstate driver uses the highest performance value to indicate > the priority of CPU. The higher value has a higher priority. > > Amd-pstate driver will provide an initial core ordering at boot time. > It relies on the CPPC interface to communicate the core ranking to the > operating system and scheduler to make sure that OS is choosing the cores > with highest performance firstly for scheduling the process. When amd-pstate > driver receives a message with the highest performance change, it will > update the core ranking. Hi Boris, You've had comments on the previous version of this. Have they all been addressed?
On Mon, Jan 29, 2024 at 04:18:02PM +0100, Rafael J. Wysocki wrote: > You've had comments on the previous version of this. > > Have they all been addressed? Yeah, see patch 1. Thx.
On Mon, Jan 29, 2024 at 4:33 PM Borislav Petkov <bp@alien8.de> wrote: > > On Mon, Jan 29, 2024 at 04:18:02PM +0100, Rafael J. Wysocki wrote: > > You've had comments on the previous version of this. > > > > Have they all been addressed? > > Yeah, see patch 1. Thanks! So the whole lot has been applied as 6.9 material, with some patch subjects changed and a couple of changelogs edited. Thank you!
Dear all, I have found an issue with the patchset when applying on 6.7, leading to a large degradation in performance. On my 7840HS on *STOCK* 6.7 highest_perf is reported as 196, not 166 as assumed in the patchset. Applying the patchset causes highest_perf to be misreported and hence a misreported maximum frequency as well, at 4.35GHz instead of 5.14GHz, leading to the degradation in performance. However, On my 5950X, highest_perf is indeed reported as 166 before and after applying the patchset. Hence, I propose the following patch (should be attached). I do apologize for any mistakes as I am new to this and this is my first email on the mailing list. Cheers! Lucas
[AMD Official Use Only - General] Hi : Thanks. I will check this issue and fix it as soon as possible. > -----Original Message----- > From: Lucas Lee Jing Yi <lucasleeeeeeeee@gmail.com> > Sent: Monday, February 19, 2024 12:11 AM > To: rafael@kernel.org > Cc: Yuan, Perry <Perry.Yuan@amd.com>; Du, Xiaojian > <Xiaojian.Du@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; bp@alien8.de; Sharma, Deepak > <Deepak.Sharma@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; > linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > kselftest@vger.kernel.org; linux-pm@vger.kernel.org; Limonciello, Mario > <Mario.Limonciello@amd.com>; Fontenot, Nathan > <Nathan.Fontenot@amd.com>; oleksandr@natalenko.name; > rafael.j.wysocki@intel.com; Huang, Ray <Ray.Huang@amd.com>; Huang, > Shimmer <Shimmer.Huang@amd.com>; skhan@linuxfoundation.org; > viresh.kumar@linaro.org; x86@kernel.org > Subject: Re: [PATCH V14 0/7] amd-pstate preferred core > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Dear all, > I have found an issue with the patchset when applying on 6.7, leading to a > large degradation in performance. > > On my 7840HS on *STOCK* 6.7 highest_perf is reported as 196, not 166 as > assumed in the patchset. Applying the patchset causes highest_perf to be > misreported and hence a misreported maximum frequency as well, at > 4.35GHz instead of 5.14GHz, leading to the degradation in performance. > However, On my 5950X, highest_perf is indeed reported as 166 before and > after applying the patchset. > > Hence, I propose the following patch (should be attached). > > I do apologize for any mistakes as I am new to this and this is my first email on > the mailing list. > > Cheers! > Lucas
Hi all: The core frequency is subjected to the process variation in semiconductors. Not all cores are able to reach the maximum frequency respecting the infrastructure limits. Consequently, AMD has redefined the concept of maximum frequency of a part. This means that a fraction of cores can reach maximum frequency. To find the best process scheduling policy for a given scenario, OS needs to know the core ordering informed by the platform through highest performance capability register of the CPPC interface. Earlier implementations of amd-pstate preferred core only support a static core ranking and targeted performance. Now it has the ability to dynamically change the preferred core based on the workload and platform conditions and accounting for thermals and aging. Amd-pstate driver utilizes the functions and data structures provided by the ITMT architecture to enable the scheduler to favor scheduling on cores which can be get a higher frequency with lower voltage. We call it amd-pstate preferred core. Here sched_set_itmt_core_prio() is called to set priorities and sched_set_itmt_support() is called to enable ITMT feature. Amd-pstate driver uses the highest performance value to indicate the priority of CPU. The higher value has a higher priority. Amd-pstate driver will provide an initial core ordering at boot time. It relies on the CPPC interface to communicate the core ranking to the operating system and scheduler to make sure that OS is choosing the cores with highest performance firstly for scheduling the process. When amd-pstate driver receives a message with the highest performance change, it will update the core ranking. Changes from V13->V14: - cpufreq: - - fix build error without CONFIG_CPU_FREQ - ACPI: CPPC: Changes from V12->V13: - ACPI: CPPC: - - modify commit message. - - modify handle function of the notify(0x85). - cpufreq: amd-pstate: - - implement update_limits() callback function. - x86: - - pick up Acked-By flag added by Petkov. Changes from V11->V12: - all: - - pick up Reviewed-By flag added by Perry. - cpufreq: amd-pstate: - - rebase the latest linux-next and fixed conflicts. - - fixed the issue about cpudata without init in amd_pstate_update_highest_perf(). Changes from V10->V11: - cpufreq: amd-pstate: - - according Perry's commnts, I replace the string with str_enabled_disable(). Changes from V9->V10: - cpufreq: amd-pstate: - - add judgement for highest_perf. When it is less than 255, the preferred core feature is enabled. And it will set the priority. - - deleset "static u32 max_highest_perf" etc, because amd p-state perferred coe does not require specail process for hotpulg. Changes form V8->V9: - all: - - pick up Tested-By flag added by Oleksandr. - cpufreq: amd-pstate: - - pick up Review-By flag added by Wyes. - - ignore modification of bug. - - add a attribute of prefcore_ranking. - - modify data type conversion from u32 to int. - Documentation: amd-pstate: - - pick up Review-By flag added by Wyes. Changes form V7->V8: - all: - - pick up Review-By flag added by Mario and Ray. - cpufreq: amd-pstate: - - use hw_prefcore embeds into cpudata structure. - - delete preferred core init from cpu online/off. Changes form V6->V7: - x86: - - Modify kconfig about X86_AMD_PSTATE. - cpufreq: amd-pstate: - - modify incorrect comments about scheduler_work(). - - convert highest_perf data type. - - modify preferred core init when cpu init and online. - ACPI: CPPC: - - modify link of CPPC highest performance. - cpufreq: - - modify link of CPPC highest performance changed. Changes form V5->V6: - cpufreq: amd-pstate: - - modify the wrong tag order. - - modify warning about hw_prefcore sysfs attribute. - - delete duplicate comments. - - modify the variable name cppc_highest_perf to prefcore_ranking. - - modify judgment conditions for setting highest_perf. - - modify sysfs attribute for CPPC highest perf to pr_debug message. - Documentation: amd-pstate: - - modify warning: title underline too short. Changes form V4->V5: - cpufreq: amd-pstate: - - modify sysfs attribute for CPPC highest perf. - - modify warning about comments - - rebase linux-next - cpufreq: - - Moidfy warning about function declarations. - Documentation: amd-pstate: - - align with ``amd-pstat`` Changes form V3->V4: - Documentation: amd-pstate: - - Modify inappropriate descriptions. Changes form V2->V3: - x86: - - Modify kconfig and description. - cpufreq: amd-pstate: - - Add Co-developed-by tag in commit message. - cpufreq: - - Modify commit message. - Documentation: amd-pstate: - - Modify inappropriate descriptions. Changes form V1->V2: - ACPI: CPPC: - - Add reference link. - cpufreq: - - Moidfy link error. - cpufreq: amd-pstate: - - Init the priorities of all online CPUs - - Use a single variable to represent the status of preferred core. - Documentation: - - Default enabled preferred core. - Documentation: amd-pstate: - - Modify inappropriate descriptions. - - Default enabled preferred core. - - Use a single variable to represent the status of preferred core. Meng Li (7): x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion. ACPI: CPPC: Add get the highest performance cppc control cpufreq: amd-pstate: Enable amd-pstate preferred core supporting. cpufreq: Add a notification message that the highest perf has changed cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically Documentation: amd-pstate: introduce amd-pstate preferred core Documentation: introduce amd-pstate preferrd core mode kernel command line options .../admin-guide/kernel-parameters.txt | 5 + Documentation/admin-guide/pm/amd-pstate.rst | 59 +++++- arch/x86/Kconfig | 5 +- drivers/acpi/cppc_acpi.c | 13 ++ drivers/acpi/processor_driver.c | 6 + drivers/cpufreq/amd-pstate.c | 183 +++++++++++++++++- include/acpi/cppc_acpi.h | 5 + include/linux/amd-pstate.h | 10 + include/linux/cpufreq.h | 1 + 9 files changed, 275 insertions(+), 12 deletions(-)