| Message ID | 20240129-rm-ext-plugins-v4-0-bfd1e08c7f99@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Remove support for external plugins | expand |
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 29 Jan 2024 14:44:14 +0000 you wrote: > Hello everyone, > > With v4 we have moved from pre-processor to compilation checking for the > external plugins support. > > Namely, as we build without one the dead-code elimination will discard > all the relevant code. Ultimately this means we compile check both paths > in order to catch mistakes. Thanks to Luiz for the suggestion. > > [...] Here is the summary with links: - [BlueZ,v4,1/8] configure, README: introduce --enable-external-plugins https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2a5c9cf632e6 - [BlueZ,v4,2/8] obexd: factor out external plugin support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=004b5b28a04c - [BlueZ,v4,3/8] bluetoothd: remove external-dummy plugin https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1db7a00e35c4 - [BlueZ,v4,4/8] bluetoothd: convert external sixaxis plugin to builtin https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9f71892b63f6 - [BlueZ,v4,5/8] bluetoothd: factor out external plugin support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=109cc8a0f6aa - [BlueZ,v4,6/8] bluetoothd: don't export internal API https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7a1d3c7c4bc7 - [BlueZ,v4,7/8] bluetoothd: change plugin loading alike obexd https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f174724c76c6 - [BlueZ,v4,8/8] android: export only (android) entrypoint from the modules https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f59f4902bc4e You are awesome, thank you!
Hello everyone, With v4 we have moved from pre-processor to compilation checking for the external plugins support. Namely, as we build without one the dead-code elimination will discard all the relevant code. Ultimately this means we compile check both paths in order to catch mistakes. Thanks to Luiz for the suggestion. Link to the previous revision can be found below. Thanks Emil - Link to v3: https://lore.kernel.org/r/20240125-rm-ext-plugins-v3-0-d141f7870bb6@gmail.com --- Emil Velikov (8): configure, README: introduce --enable-external-plugins obexd: factor out external plugin support bluetoothd: remove external-dummy plugin bluetoothd: convert external sixaxis plugin to builtin bluetoothd: factor out external plugin support bluetoothd: don't export internal API bluetoothd: change plugin loading alike obexd android: export only (android) entrypoint from the modules Makefile.am | 17 ++---- Makefile.obexd | 2 + Makefile.plugins | 8 ++- README | 13 +++++ android/Makefile.am | 3 ++ android/hal-audio.c | 1 + android/hal-bluetooth.c | 1 + android/hal-sco.c | 1 + configure.ac | 10 ++++ obexd/src/obexd.h | 2 +- obexd/src/plugin.c | 89 ++++++++++++++++++++----------- obexd/src/plugin.h | 4 ++ plugins/external-dummy.c | 28 ---------- src/btd.h | 2 +- src/plugin.c | 135 ++++++++++++++++++++++++++++------------------- src/plugin.h | 4 ++ 16 files changed, 188 insertions(+), 132 deletions(-) --- base-commit: 0de32f67f685b95c35a5c2f1206081af89bd88b6 change-id: 20240116-rm-ext-plugins-ba0b852a492b Best regards,