mbox series

[v2,0/7] arm64: sun50i-h616: Add DMA and SPDIF controllers

Message ID 20240127163247.384439-1-wens@kernel.org (mailing list archive)
Headers show
Series arm64: sun50i-h616: Add DMA and SPDIF controllers | expand

Message

Chen-Yu Tsai Jan. 27, 2024, 4:32 p.m. UTC
From: Chen-Yu Tsai <wens@csie.org>

Hi everyone,

This is v2 of my H616/H618 DMA and SPDIF controller series.

Changes since v1:
- Switch to "contains" for if-properties statement
- Fall back to A100 instead of H6
- Add DMA channels for r_i2c

This series adds DMA and SPDIF controllers for the H616 and H618.
There's also a fix for SPDIF on H6: the controller also has a
receiver that was not correctly modeled.

Patch 1 fixes the binding for the SPDIF controller on the H6 by adding
the RX DMA channel.

Patch 2 adds a compatible string for the H616's SPDIF transmitter to the
binding.

Patch 3 adds a compatible string for the H616's SPDIF transmitter to the
driver.

Patch 4 adds a compatible string for the H616's DMA controller.

Patch 5 adds the RX DMA channel to the SPDIF controller on the H6.

Patch 6 adds a device node for the H616's DMA controller.

Patch 7 adds a device node for the H616's SPDIF controller.


This was tested on the Orange Pi Zero 3 with SPI flash transfers and
SPDIF audio output. The H6 SPDIF change is superficial as the driver
does not support receiving / capturing an audio stream.

Please have a look. I expect the first three patches to go through the
ASoC tree, the fourth patch to either go through the DMA tree, or
through the sunxi tree with an Ack, and the last three through the sunxi
tree.


Thanks
ChenYu


Chen-Yu Tsai (7):
  dt-bindings: sound: sun4i-spdif: Fix requirements for H6
  dt-bindings: sound: sun4i-spdif: Add Allwinner H616 compatible
  ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616
  dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616
  arm64: dts: allwinner: h6: Add RX DMA channel for SPDIF
  arm64: dts: allwinner: h616: Add DMA controller and DMA channels
  arm64: dts: allwinner: h616: Add SPDIF device node

 .../dma/allwinner,sun50i-a64-dma.yaml         | 12 ++--
 .../sound/allwinner,sun4i-a10-spdif.yaml      |  5 +-
 .../dts/allwinner/sun50i-h6-beelink-gs1.dts   |  2 +
 .../boot/dts/allwinner/sun50i-h6-tanix.dtsi   |  2 +
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi  |  7 +--
 .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 61 +++++++++++++++++++
 sound/soc/sunxi/sun4i-spdif.c                 |  5 ++
 7 files changed, 85 insertions(+), 9 deletions(-)

Comments

Mark Brown Jan. 29, 2024, 4:55 p.m. UTC | #1
On Sun, Jan 28, 2024 at 12:32:40AM +0800, Chen-Yu Tsai wrote:

> Chen-Yu Tsai (7):
>   dt-bindings: sound: sun4i-spdif: Fix requirements for H6
>   dt-bindings: sound: sun4i-spdif: Add Allwinner H616 compatible

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Mark Brown Jan. 29, 2024, 11:08 p.m. UTC | #2
On Sun, 28 Jan 2024 00:32:40 +0800, Chen-Yu Tsai wrote:
> This is v2 of my H616/H618 DMA and SPDIF controller series.
> 
> Changes since v1:
> - Switch to "contains" for if-properties statement
> - Fall back to A100 instead of H6
> - Add DMA channels for r_i2c
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] dt-bindings: sound: sun4i-spdif: Fix requirements for H6
      commit: 57b3c130d97e45b8a07586e0ae113e43776c5ea8
[2/7] dt-bindings: sound: sun4i-spdif: Add Allwinner H616 compatible
      commit: 7a9dc944f129bb56ef855d9c0b0647bc3e98a56f
[3/7] ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616
      commit: 0adf963b8463faa44653e22e56ce55f747e68868

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Vinod Koul Jan. 30, 2024, 4:50 p.m. UTC | #3
On Sun, 28 Jan 2024 00:32:40 +0800, Chen-Yu Tsai wrote:
> This is v2 of my H616/H618 DMA and SPDIF controller series.
> 
> Changes since v1:
> - Switch to "contains" for if-properties statement
> - Fall back to A100 instead of H6
> - Add DMA channels for r_i2c
> 
> [...]

Applied, thanks!

[4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616
      commit: b32eb97edeb8d69092d57419917b19c909ff962a

Best regards,
Jernej Škrabec Jan. 30, 2024, 7:48 p.m. UTC | #4
Dne sobota, 27. januar 2024 ob 17:32:40 CET je Chen-Yu Tsai napisal(a):
> From: Chen-Yu Tsai <wens@csie.org>
> 
> Hi everyone,
> 
> This is v2 of my H616/H618 DMA and SPDIF controller series.
> 
> Changes since v1:
> - Switch to "contains" for if-properties statement
> - Fall back to A100 instead of H6
> - Add DMA channels for r_i2c
> 
> This series adds DMA and SPDIF controllers for the H616 and H618.
> There's also a fix for SPDIF on H6: the controller also has a
> receiver that was not correctly modeled.
> 
> Patch 1 fixes the binding for the SPDIF controller on the H6 by adding
> the RX DMA channel.
> 
> Patch 2 adds a compatible string for the H616's SPDIF transmitter to the
> binding.
> 
> Patch 3 adds a compatible string for the H616's SPDIF transmitter to the
> driver.
> 
> Patch 4 adds a compatible string for the H616's DMA controller.
> 
> Patch 5 adds the RX DMA channel to the SPDIF controller on the H6.
> 
> Patch 6 adds a device node for the H616's DMA controller.
> 
> Patch 7 adds a device node for the H616's SPDIF controller.
> 
> 
> This was tested on the Orange Pi Zero 3 with SPI flash transfers and
> SPDIF audio output. The H6 SPDIF change is superficial as the driver
> does not support receiving / capturing an audio stream.
> 
> Please have a look. I expect the first three patches to go through the
> ASoC tree, the fourth patch to either go through the DMA tree, or
> through the sunxi tree with an Ack, and the last three through the sunxi
> tree.
> 
> 
> Thanks
> ChenYu
> 
> 
> Chen-Yu Tsai (7):
>   dt-bindings: sound: sun4i-spdif: Fix requirements for H6
>   dt-bindings: sound: sun4i-spdif: Add Allwinner H616 compatible
>   ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616
>   dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616
>   arm64: dts: allwinner: h6: Add RX DMA channel for SPDIF
>   arm64: dts: allwinner: h616: Add DMA controller and DMA channels
>   arm64: dts: allwinner: h616: Add SPDIF device node
> 
>  .../dma/allwinner,sun50i-a64-dma.yaml         | 12 ++--
>  .../sound/allwinner,sun4i-a10-spdif.yaml      |  5 +-
>  .../dts/allwinner/sun50i-h6-beelink-gs1.dts   |  2 +
>  .../boot/dts/allwinner/sun50i-h6-tanix.dtsi   |  2 +
>  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi  |  7 +--
>  .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 61 +++++++++++++++++++
>  sound/soc/sunxi/sun4i-spdif.c                 |  5 ++
>  7 files changed, 85 insertions(+), 9 deletions(-)
> 
> 

Applied patches 5-7 to sunxi tree, thanks!

Best regards,
Jernej