mbox series

[v4,0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

Message ID 20240124100019.290120-1-dharma.b@microchip.com (mailing list archive)
Headers show
Series Convert Microchip's HLCDC Text based DT bindings to JSON schema | expand

Message

Dharma Balasubiramani Jan. 24, 2024, 10 a.m. UTC 
Converted the text bindings to YAML and validated them individually using following commands

$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/

changelogs are available in respective patches.

As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
will be sent as separate patch.

Dharma Balasubiramani (3):
  dt-bindings: display: convert Atmel's HLCDC to DT schema
  dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema
  dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

 .../atmel/atmel,hlcdc-display-controller.yaml | 85 ++++++++++++++++
 .../bindings/display/atmel/hlcdc-dc.txt       | 75 --------------
 .../devicetree/bindings/mfd/atmel,hlcdc.yaml  | 97 +++++++++++++++++++
 .../devicetree/bindings/mfd/atmel-hlcdc.txt   | 56 -----------
 .../bindings/pwm/atmel,hlcdc-pwm.yaml         | 44 +++++++++
 .../bindings/pwm/atmel-hlcdc-pwm.txt          | 29 ------
 6 files changed, 226 insertions(+), 160 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml
 delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt

Comments

Conor Dooley Jan. 24, 2024, 4:40 p.m. UTC | #1 
On Wed, Jan 24, 2024 at 03:30:16PM +0530, Dharma Balasubiramani wrote:
> Converted the text bindings to YAML and validated them individually using following commands
> 
> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> 
> changelogs are available in respective patches.
> 
> As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
> will be sent as separate patch.

Please give discussion on the previous version some time to complete
before sending a new one. I've still got questions about the clocks
there.

Thanks,
Conor.
Dharma Balasubiramani Jan. 30, 2024, 6:42 a.m. UTC | #2 
Hi Conor,

On 24/01/24 10:10 pm, Conor Dooley wrote:
> On Wed, Jan 24, 2024 at 03:30:16PM +0530, Dharma Balasubiramani wrote:
>> Converted the text bindings to YAML and validated them individually using following commands
>>
>> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
>> $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
>>
>> changelogs are available in respective patches.
>>
>> As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
>> will be sent as separate patch.
> Please give discussion on the previous version some time to complete
> before sending a new one. I've still got questions about the clocks
> there.

Could you please give a green signal to proceed with the v5 patch series 
with the following changes only in PATCH 3/3?

+  clocks:
+    minItems: 3
+
+  clock-names:
+    items:
+      - const: periph_clk
+      - const: sys_clk
+      - const: slow_clk
+      - const: lvds_pll_clk

> 
> Thanks,
> Conor.
Conor Dooley Jan. 30, 2024, 4:57 p.m. UTC | #3 
On Tue, Jan 30, 2024 at 06:42:04AM +0000, Dharma.B@microchip.com wrote:
> Hi Conor,
> 
> On 24/01/24 10:10 pm, Conor Dooley wrote:
> > On Wed, Jan 24, 2024 at 03:30:16PM +0530, Dharma Balasubiramani wrote:
> >> Converted the text bindings to YAML and validated them individually using following commands
> >>
> >> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> >> $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> >>
> >> changelogs are available in respective patches.
> >>
> >> As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch
> >> will be sent as separate patch.
> > Please give discussion on the previous version some time to complete
> > before sending a new one. I've still got questions about the clocks
> > there.
> 
> Could you please give a green signal to proceed with the v5 patch series 
> with the following changes only in PATCH 3/3?

Didn't we just decide on what to do on the v3 thread yesterday?
Go with that.

> +  clocks:
> +    minItems: 3
> +
> +  clock-names:
> +    items:
> +      - const: periph_clk
> +      - const: sys_clk
> +      - const: slow_clk
> +      - const: lvds_pll_clk
> 
> > 
> > Thanks,
> > Conor.
> 
> -- 
> With Best Regards,
> Dharma B.
>