| Message ID | 20240129145916.244193-1-jiri@resnulli.us (mailing list archive) |
|---|---|
| Headers | show |
| Series | dpll: expose lock status error value to user | expand |
On 29/01/2024 14:59, Jiri Pirko wrote: > From: Jiri Pirko <jiri@nvidia.com> > > Allow to expose lock status errort value over new DPLL generic netlink > attribute. Extend the lock_status_get() op by new argument to get the > value from the driver. Implement this new argument fill-up > in mlx5 driver. The list of errors shows that the focus is on SyncE devices here. What do you think about extending it to PPS devices too? Like loss of input frequency, or high phase offset? But the series overall looks good, Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev> > Jiri Pirko (3): > dpll: extend uapi by lock status error attribute > dpll: extend lock_status_get() op by status error and expose to user > net/mlx5: DPLL, Implement lock status error value > > Documentation/netlink/specs/dpll.yaml | 39 +++++++++++++++++++ > drivers/dpll/dpll_netlink.c | 9 ++++- > drivers/net/ethernet/intel/ice/ice_dpll.c | 1 + > .../net/ethernet/mellanox/mlx5/core/dpll.c | 32 +++++++++++++-- > drivers/ptp/ptp_ocp.c | 9 +++-- > include/linux/dpll.h | 1 + > include/linux/mlx5/mlx5_ifc.h | 8 ++++ > include/uapi/linux/dpll.h | 30 ++++++++++++++ > 8 files changed, 120 insertions(+), 9 deletions(-) >
Tue, Jan 30, 2024 at 11:28:56AM CET, vadim.fedorenko@linux.dev wrote: >On 29/01/2024 14:59, Jiri Pirko wrote: >> From: Jiri Pirko <jiri@nvidia.com> >> >> Allow to expose lock status errort value over new DPLL generic netlink >> attribute. Extend the lock_status_get() op by new argument to get the >> value from the driver. Implement this new argument fill-up >> in mlx5 driver. > >The list of errors shows that the focus is on SyncE devices here. What >do you think about extending it to PPS devices too? Like loss of input >frequency, or high phase offset? Sure, lets add it if that suits you. There is certainly room for extensions of values here :) > >But the series overall looks good, > >Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev> > > >> Jiri Pirko (3): >> dpll: extend uapi by lock status error attribute >> dpll: extend lock_status_get() op by status error and expose to user >> net/mlx5: DPLL, Implement lock status error value >> >> Documentation/netlink/specs/dpll.yaml | 39 +++++++++++++++++++ >> drivers/dpll/dpll_netlink.c | 9 ++++- >> drivers/net/ethernet/intel/ice/ice_dpll.c | 1 + >> .../net/ethernet/mellanox/mlx5/core/dpll.c | 32 +++++++++++++-- >> drivers/ptp/ptp_ocp.c | 9 +++-- >> include/linux/dpll.h | 1 + >> include/linux/mlx5/mlx5_ifc.h | 8 ++++ >> include/uapi/linux/dpll.h | 30 ++++++++++++++ >> 8 files changed, 120 insertions(+), 9 deletions(-) >> >
From: Jiri Pirko <jiri@nvidia.com> Allow to expose lock status errort value over new DPLL generic netlink attribute. Extend the lock_status_get() op by new argument to get the value from the driver. Implement this new argument fill-up in mlx5 driver. Jiri Pirko (3): dpll: extend uapi by lock status error attribute dpll: extend lock_status_get() op by status error and expose to user net/mlx5: DPLL, Implement lock status error value Documentation/netlink/specs/dpll.yaml | 39 +++++++++++++++++++ drivers/dpll/dpll_netlink.c | 9 ++++- drivers/net/ethernet/intel/ice/ice_dpll.c | 1 + .../net/ethernet/mellanox/mlx5/core/dpll.c | 32 +++++++++++++-- drivers/ptp/ptp_ocp.c | 9 +++-- include/linux/dpll.h | 1 + include/linux/mlx5/mlx5_ifc.h | 8 ++++ include/uapi/linux/dpll.h | 30 ++++++++++++++ 8 files changed, 120 insertions(+), 9 deletions(-)