[vhost,00/14] virtio remove dma info for premapped mode

Message

Xuan Zhuo Jan. 30, 2024, 3:05 a.m. UTC

As discussed:
http://lore.kernel.org/all/[e-mail]

If the virtio is premapped mode, the driver should manage the dma info by self.
So the virtio core should not store the dma info.
So we can release the memory used to store the dma info.

But if the desc_extra has not dma info, we face a new question,
it is hard to get the dma info of the desc with indirect flag.
For split mode, that is easy from desc, but for the packed mode,
it is hard to get the dma info from the desc. And for hardening
the dma unmap is saft, we should store the dma info of indirect
descs.

So I introduce the "structure the indirect desc table" to
allocate space to store dma info with the desc table.

On the other side, we mix the descs with indirect flag
with other descs together to share the unmap api. That
is complex. I found if we we distinguish the descs with
VRING_DESC_F_INDIRECT before unmap, thing will be clearer.

Because of the dma array is allocated in the find_vqs(),
so I introduce a new parameter to find_vqs().

Please review.

Thanks

Xuan Zhuo (14):
  virtio_ring: introduce vring_need_unmap_buffer
  virtio_ring: packed: remove double check of the unmap ops
  virtio_ring: packed: structure the indirect desc table
  virtio_ring: split: remove double check of the unmap ops
  virtio_ring: split: structure the indirect desc table
  virtio_ring: no store dma info when unmap is not needed
  virtio_ring: introduce dma map api for page
  virtio: find_vqs introduce premapped parameter
  virtio_ring: export premapped to driver by struct virtqueue
  virtio_net: set premapped mode by find_vqs()
  virtio_ring: remove api of setting vq premapped
  virtio_net: unify the code for recycling the xmit ptr
  virtio_net: rename free_old_xmit_skbs to free_old_xmit
  virtio_net: sq support premapped mode

 arch/um/drivers/virtio_uml.c             |   5 +-
 drivers/net/virtio_net.c                 | 291 +++++++++----
 drivers/platform/mellanox/mlxbf-tmfifo.c |   3 +-
 drivers/remoteproc/remoteproc_virtio.c   |   9 +-
 drivers/s390/virtio/virtio_ccw.c         |   8 +-
 drivers/virtio/virtio_mmio.c             |   8 +-
 drivers/virtio/virtio_pci_common.c       |  15 +-
 drivers/virtio/virtio_pci_common.h       |   2 +
 drivers/virtio/virtio_pci_legacy.c       |   3 +-
 drivers/virtio/virtio_pci_modern.c       |   6 +-
 drivers/virtio/virtio_ring.c             | 511 +++++++++++++----------
 drivers/virtio/virtio_vdpa.c             |   6 +-
 include/linux/virtio.h                   |  10 +-
 include/linux/virtio_config.h            |  19 +-
 include/linux/virtio_ring.h              |   3 +
 tools/virtio/linux/virtio.h              |   1 +
 tools/virtio/virtio_test.c               |   2 +-
 tools/virtio/vringh_test.c               |  10 +-
 18 files changed, 585 insertions(+), 327 deletions(-)

--
2.32.0.3.g01195cf9f

Comments

Xuan Zhuo Jan. 30, 2024, 11:43 a.m. UTC | #1

Please ignore this.

The new thread is sent.

	[PATCH vhost 00/17] virtio: drivers maintain dma info for premapped vq

	http://lore.kernel.org/all/[e-mail]

That includes the refactor of find_vqs().

Thanks.