| Message ID | 878r49klg1.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | of: property: add port base loop | expand |
Hi Kuninori, kernel test robot noticed the following build errors: [auto build test ERROR on broonie-sound/for-next] [also build test ERROR on drm-misc/drm-misc-next linus/master v6.8-rc2 next-20240130] [cannot apply to robh/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kuninori-Morimoto/of-property-add-port-base-loop/20240129-085726 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/878r49klg1.wl-kuninori.morimoto.gx%40renesas.com patch subject: [PATCH v2 05/13] media: xilinx-tpg: use of_graph_get_next_endpoint_raw() config: mips-randconfig-r113-20240130 (https://download.01.org/0day-ci/archive/20240130/202401302148.K0ZR110q-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce: (https://download.01.org/0day-ci/archive/20240130/202401302148.K0ZR110q-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401302148.K0ZR110q-lkp@intel.com/ All error/warnings (new ones prefixed by >>): >> drivers/media/platform/xilinx/xilinx-tpg.c:747:15: error: implicit declaration of function 'of_graph_get_next_endpoint_raw' is invalid in C99 [-Werror,-Wimplicit-function-declaration] endpoint = of_graph_get_next_endpoint_raw(port, NULL); ^ drivers/media/platform/xilinx/xilinx-tpg.c:747:15: note: did you mean 'acpi_graph_get_next_endpoint'? include/linux/acpi.h:1409:1: note: 'acpi_graph_get_next_endpoint' declared here acpi_graph_get_next_endpoint(const struct fwnode_handle *fwnode, ^ >> drivers/media/platform/xilinx/xilinx-tpg.c:747:13: warning: incompatible integer to pointer conversion assigning to 'struct device_node *' from 'int' [-Wint-conversion] endpoint = of_graph_get_next_endpoint_raw(port, NULL); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning and 1 error generated. vim +/of_graph_get_next_endpoint_raw +747 drivers/media/platform/xilinx/xilinx-tpg.c 705 706 /* ----------------------------------------------------------------------------- 707 * Platform Device Driver 708 */ 709 710 static int xtpg_parse_of(struct xtpg_device *xtpg) 711 { 712 struct device *dev = xtpg->xvip.dev; 713 struct device_node *node = xtpg->xvip.dev->of_node; 714 struct device_node *ports; 715 struct device_node *port; 716 unsigned int nports = 0; 717 bool has_endpoint = false; 718 719 ports = of_get_child_by_name(node, "ports"); 720 if (ports == NULL) 721 ports = node; 722 723 for_each_child_of_node(ports, port) { 724 const struct xvip_video_format *format; 725 struct device_node *endpoint; 726 727 if (!of_node_name_eq(port, "port")) 728 continue; 729 730 format = xvip_of_get_format(port); 731 if (IS_ERR(format)) { 732 dev_err(dev, "invalid format in DT"); 733 of_node_put(port); 734 return PTR_ERR(format); 735 } 736 737 /* Get and check the format description */ 738 if (!xtpg->vip_format) { 739 xtpg->vip_format = format; 740 } else if (xtpg->vip_format != format) { 741 dev_err(dev, "in/out format mismatch in DT"); 742 of_node_put(port); 743 return -EINVAL; 744 } 745 746 if (nports == 0) { > 747 endpoint = of_graph_get_next_endpoint_raw(port, NULL); 748 if (endpoint) 749 has_endpoint = true; 750 of_node_put(endpoint); 751 } 752 753 /* Count the number of ports. */ 754 nports++; 755 } 756 757 if (nports != 1 && nports != 2) { 758 dev_err(dev, "invalid number of ports %u\n", nports); 759 return -EINVAL; 760 } 761 762 xtpg->npads = nports; 763 if (nports == 2 && has_endpoint) 764 xtpg->has_input = true; 765 766 return 0; 767 } 768
diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c b/drivers/media/platform/xilinx/xilinx-tpg.c index 80353ca44402..97908533466c 100644 --- a/drivers/media/platform/xilinx/xilinx-tpg.c +++ b/drivers/media/platform/xilinx/xilinx-tpg.c @@ -745,7 +745,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg) } if (nports == 0) { - endpoint = of_get_next_child(port, NULL); + endpoint = of_graph_get_next_endpoint_raw(port, NULL); if (endpoint) has_endpoint = true; of_node_put(endpoint);
We can now use of_graph_get_next_endpoint_raw(), let's use it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/media/platform/xilinx/xilinx-tpg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)