| Message ID | 20240130-galaxy-tab-s-cleanup-v1-1-d4e17857241d@grimler.se (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: samsung: enable wifi and cleanup exynos5420-galaxy-tab dts'es | expand |
On 30/01/2024 21:40, Henrik Grimler wrote: > Sort all node properties according to dts coding style guidelines, to > make dtsi easier to follow. > > Signed-off-by: Henrik Grimler <henrik@grimler.se> > --- > .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++----------- > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi > index f525b2f5e4e0..0c1aeafc025b 100644 > --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi > @@ -103,8 +103,8 @@ &cpu4 { > }; > > &gpu { > - status = "okay"; > mali-supply = <&buck4_reg>; > + status = "okay"; Such changes should come from a tool, but since we do not have them, I don't want to bother with properties re-shuffling. Best regards, Krzysztof
Hi Krzysztof, On Wed, Jan 31, 2024 at 08:19:39AM +0100, Krzysztof Kozlowski wrote: > On 30/01/2024 21:40, Henrik Grimler wrote: > > Sort all node properties according to dts coding style guidelines, to > > make dtsi easier to follow. > > > > Signed-off-by: Henrik Grimler <henrik@grimler.se> > > --- > > .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++----------- > > 1 file changed, 11 insertions(+), 12 deletions(-) > > > > diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi > > index f525b2f5e4e0..0c1aeafc025b 100644 > > --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi > > +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi > > @@ -103,8 +103,8 @@ &cpu4 { > > }; > > > > &gpu { > > - status = "okay"; > > mali-supply = <&buck4_reg>; > > + status = "okay"; > > Such changes should come from a tool, but since we do not have them, I > don't want to bother with properties re-shuffling. Noted, thanks. I will drop this patch and send a v2 in a few hours. > Best regards, > Krzysztof Best regards Henrik Grimler
On 31/01/2024 09:25, Henrik Grimler wrote: > Hi Krzysztof, > > On Wed, Jan 31, 2024 at 08:19:39AM +0100, Krzysztof Kozlowski wrote: >> On 30/01/2024 21:40, Henrik Grimler wrote: >>> Sort all node properties according to dts coding style guidelines, to >>> make dtsi easier to follow. >>> >>> Signed-off-by: Henrik Grimler <henrik@grimler.se> >>> --- >>> .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++----------- >>> 1 file changed, 11 insertions(+), 12 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi >>> index f525b2f5e4e0..0c1aeafc025b 100644 >>> --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi >>> +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi >>> @@ -103,8 +103,8 @@ &cpu4 { >>> }; >>> >>> &gpu { >>> - status = "okay"; >>> mali-supply = <&buck4_reg>; >>> + status = "okay"; >> >> Such changes should come from a tool, but since we do not have them, I >> don't want to bother with properties re-shuffling. > > Noted, thanks. I will drop this patch and send a v2 in a few hours. No need for v2, unless some other comments pop up. I will just apply #2 and #3 from this set. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi index f525b2f5e4e0..0c1aeafc025b 100644 --- a/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi +++ b/arch/arm/boot/dts/samsung/exynos5420-galaxy-tab-common.dtsi @@ -103,8 +103,8 @@ &cpu4 { }; &gpu { - status = "okay"; mali-supply = <&buck4_reg>; + status = "okay"; }; &hsi2c_7 { @@ -113,11 +113,10 @@ &hsi2c_7 { pmic@66 { compatible = "samsung,s2mps11-pmic"; reg = <0x66>; - interrupt-parent = <&gpx3>; interrupts = <2 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names = "default"; pinctrl-0 = <&s2mps11_irq>; + pinctrl-names = "default"; s2mps11_osc: clocks { compatible = "samsung,s2mps11-clk"; @@ -605,7 +604,6 @@ &mixer { /* Internal storage */ &mmc_0 { - status = "okay"; bus-width = <8>; cap-mmc-highspeed; card-detect-delay = <200>; @@ -614,27 +612,28 @@ &mmc_0 { non-removable; pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8>; pinctrl-names = "default"; + vqmmc-supply = <&ldo3_reg>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-ddr-timing = <0 2>; samsung,dw-mshc-sdr-timing = <0 4>; - vqmmc-supply = <&ldo3_reg>; + status = "okay"; }; /* External sdcard */ &mmc_2 { - status = "okay"; bus-width = <4>; cap-sd-highspeed; card-detect-delay = <200>; cd-gpios = <&gpx2 4 GPIO_ACTIVE_LOW>; pinctrl-0 = <&sd2_clk &sd2_cmd &mmc2_cd &sd2_bus1 &sd2_bus4>; pinctrl-names = "default"; - samsung,dw-mshc-ciu-div = <3>; - samsung,dw-mshc-ddr-timing = <0 2>; - samsung,dw-mshc-sdr-timing = <0 4>; sd-uhs-sdr50; vmmc-supply = <&ldo19_reg>; vqmmc-supply = <&ldo13_reg>; + samsung,dw-mshc-ciu-div = <3>; + samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-sdr-timing = <0 4>; + status = "okay"; }; &pinctrl_0 { @@ -652,9 +651,9 @@ s2mps11_irq: s2mps11-irq-pins { }; &rtc { - status = "okay"; clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; clock-names = "rtc", "rtc_src"; + status = "okay"; }; &tmu_cpu0 { @@ -686,11 +685,11 @@ &usbdrd_dwc3_1 { }; &usbdrd3_0 { - vdd33-supply = <&ldo9_reg>; vdd10-supply = <&ldo11_reg>; + vdd33-supply = <&ldo9_reg>; }; &usbdrd3_1 { - vdd33-supply = <&ldo9_reg>; vdd10-supply = <&ldo11_reg>; + vdd33-supply = <&ldo9_reg>; };
Sort all node properties according to dts coding style guidelines, to make dtsi easier to follow. Signed-off-by: Henrik Grimler <henrik@grimler.se> --- .../dts/samsung/exynos5420-galaxy-tab-common.dtsi | 23 +++++++++++----------- 1 file changed, 11 insertions(+), 12 deletions(-)