| Message ID | 20240130-pm4125-typec-v1-2-e8d0097e2991@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: qrb2210-rb1: enable Type-C support | expand |
On 30/01/2024 20:42, Dmitry Baryshkov wrote: > The PM4125 PMIC has the same Type-C register block as the PMI632. > Likewise it doesn't support USB Power Delivery. Define the compatible > for the TypeC block found on PM4125, using PMI632 as a compatible. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > index 6c0c6b337693..9750cbb7558c 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > @@ -14,9 +14,15 @@ description: > > properties: > compatible: > - enum: > - - qcom,pmi632-typec > - - qcom,pm8150b-typec > + oneOf: > + - enum: > + - qcom,pmi632-typec > + - qcom,pm8150b-typec > + - items: > + - enum: > + - qcom,pm4125-typec > + - const: qcom,pmi632-typec > + > > connector: > type: object > @@ -93,6 +99,7 @@ allOf: > contains: > enum: > - qcom,pmi632-typec > + - qcom,pm4125-typec This should not be needed. You have 632 fallback present here. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml index 6c0c6b337693..9750cbb7558c 100644 --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml @@ -14,9 +14,15 @@ description: properties: compatible: - enum: - - qcom,pmi632-typec - - qcom,pm8150b-typec + oneOf: + - enum: + - qcom,pmi632-typec + - qcom,pm8150b-typec + - items: + - enum: + - qcom,pm4125-typec + - const: qcom,pmi632-typec + connector: type: object @@ -93,6 +99,7 @@ allOf: contains: enum: - qcom,pmi632-typec + - qcom,pm4125-typec then: properties: reg:
The PM4125 PMIC has the same Type-C register block as the PMI632. Likewise it doesn't support USB Power Delivery. Define the compatible for the TypeC block found on PM4125, using PMI632 as a compatible. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)