| Message ID | 20240122212848.3645785-13-dima.fedrau@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY | expand |
On Mon, Jan 22, 2024 at 10:28:45PM +0100, Dimitri Fedrau wrote: > mv88q2xxx_config_init calls genphy_c45_read_pma which is done by > mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is > also called by the PHY state machine. Let the PHY state machine handle > the phydriver ops in their intendend way. > > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Am Wed, Jan 31, 2024 at 04:21:44PM +0100 schrieb Andrew Lunn: > On Mon, Jan 22, 2024 at 10:28:45PM +0100, Dimitri Fedrau wrote: > > mv88q2xxx_config_init calls genphy_c45_read_pma which is done by > > mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is > > also called by the PHY state machine. Let the PHY state machine handle > > the phydriver ops in their intendend way. > > > > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Thanks, for reviewing. Is there a chance that you also have a look on patch 13 of the series ? It relies on this patch.
diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c index e40ea351fcde..081ed110c87e 100644 --- a/drivers/net/phy/marvell-88q2xxx.c +++ b/drivers/net/phy/marvell-88q2xxx.c @@ -367,20 +367,13 @@ static int mv88q2xxx_config_aneg(struct phy_device *phydev) static int mv88q2xxx_config_init(struct phy_device *phydev) { - int ret; - /* The 88Q2XXX PHYs do have the extended ability register available, but * register MDIO_PMA_EXTABLE where they should signalize it does not * work according to specification. Therefore, we force it here. */ phydev->pma_extable = MDIO_PMA_EXTABLE_BT1; - /* Read the current PHY configuration */ - ret = genphy_c45_read_pma(phydev); - if (ret) - return ret; - - return mv88q2xxx_config_aneg(phydev); + return 0; } static int mv88q2xxx_get_sqi(struct phy_device *phydev)
mv88q2xxx_config_init calls genphy_c45_read_pma which is done by mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is also called by the PHY state machine. Let the PHY state machine handle the phydriver ops in their intendend way. Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com> --- drivers/net/phy/marvell-88q2xxx.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)