| Message ID | 20240130093812.1746512-2-andre.draszik@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gs101 oriole: peripheral block 0 (peric0) fixes | expand |
On 30/01/2024 10:36, André Draszik wrote: > This pclk clock is required any time we access the pinctrl registers of > this block. > > Since pinctrl-samsung doesn't support a clock at the moment, we just > keep the kernel from disabling it at boot, until we have an update for > pinctrl-samsung to handle this required clock, at which point we'll be > able to drop the flag again. > > Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Dropped fixes tag. The driver looks correct, it's pinctrl issue. I really dislike how these patches are inter-mixed with DTS. Makes applying difficult and confuses about dependencies. I assume there are no dependencies here. I am repeating this and repeating, but in future I will just reject the patches: Your DTS and driver changes cannot depend on each other for new feature submissions. Best regards, Krzysztof
On Tue, 30 Jan 2024 09:36:40 +0000, André Draszik wrote: > This pclk clock is required any time we access the pinctrl registers of > this block. > > Since pinctrl-samsung doesn't support a clock at the moment, we just > keep the kernel from disabling it at boot, until we have an update for > pinctrl-samsung to handle this required clock, at which point we'll be > able to drop the flag again. > > [...] Applied, thanks! [1/6] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on https://git.kernel.org/krzk/linux/c/8a96d2701f7c794e45102a9cc7fc4a5c4951e699 Best regards,
diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 4a0520e825b6..61bb0dcf84ee 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2848,7 +2848,7 @@ static const struct samsung_gate_clock peric0_gate_clks[] __initconst = { GATE(CLK_GOUT_PERIC0_GPIO_PERIC0_PCLK, "gout_peric0_gpio_peric0_pclk", "mout_peric0_bus_user", CLK_CON_GAT_GOUT_BLK_PERIC0_UID_GPIO_PERIC0_IPCLKPORT_PCLK, - 21, 0, 0), + 21, CLK_IGNORE_UNUSED, 0), /* Disabling this clock makes the system hang. Mark the clock as critical. */ GATE(CLK_GOUT_PERIC0_LHM_AXI_P_PERIC0_I_CLK, "gout_peric0_lhm_axi_p_peric0_i_clk", "mout_peric0_bus_user",
This pclk clock is required any time we access the pinctrl registers of this block. Since pinctrl-samsung doesn't support a clock at the moment, we just keep the kernel from disabling it at boot, until we have an update for pinctrl-samsung to handle this required clock, at which point we'll be able to drop the flag again. Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0") Signed-off-by: André Draszik <andre.draszik@linaro.org> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> Reviewed-by: Peter Griffin <peter.griffin@linaro.org> --- v2: collect Reviewed-by: tags --- drivers/clk/samsung/clk-gs101.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)