| Message ID | 20240131033523.577450-1-dharma.b@microchip.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Convert Microchip's HLCDC Text based DT bindings to JSON schema | expand |
Hi Rob, On 31/01/24 9:05 am, Dharma B - I70843 wrote: > Converted the text bindings to YAML and validated them individually using following commands > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ > $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ > > changelogs are available in respective patches. > > As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch > will be sent as separate patch. > I would want to know if I can have the examples in display and pwm bindings separately or if I have to delete them from both and have a single, comprehensive example in mfd binding. I'm a little puzzled about this. > Dharma Balasubiramani (3): > dt-bindings: display: convert Atmel's HLCDC to DT schema > dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema > dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format > > .../atmel/atmel,hlcdc-display-controller.yaml | 85 ++++++++++++++++ > .../bindings/display/atmel/hlcdc-dc.txt | 75 -------------- > .../devicetree/bindings/mfd/atmel,hlcdc.yaml | 99 +++++++++++++++++++ > .../devicetree/bindings/mfd/atmel-hlcdc.txt | 56 ----------- > .../bindings/pwm/atmel,hlcdc-pwm.yaml | 44 +++++++++ > .../bindings/pwm/atmel-hlcdc-pwm.txt | 29 ------ > 6 files changed, 228 insertions(+), 160 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/atmel/atmel,hlcdc-display-controller.yaml > delete mode 100644 Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt > create mode 100644 Documentation/devicetree/bindings/mfd/atmel,hlcdc.yaml > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > create mode 100644 Documentation/devicetree/bindings/pwm/atmel,hlcdc-pwm.yaml > delete mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt >
On Thu, Feb 01, 2024 at 03:38:37AM +0000, Dharma.B@microchip.com wrote: > Hi Rob, > > On 31/01/24 9:05 am, Dharma B - I70843 wrote: > > Converted the text bindings to YAML and validated them individually using following commands > > > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ > > $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ > > > > changelogs are available in respective patches. > > > > As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch > > will be sent as separate patch. > > > > I would want to know if I can have the examples in display and pwm > bindings separately or if I have to delete them from both and have a > single, comprehensive example in mfd binding. I'm a little puzzled about > this. The strong preference is 1 complete example in the MFD binding. That avoids 2 copies of the same thing, issues with incomplete examples, and temporary warnings bisecting the series. Rob
On 02/02/24 4:06 am, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, Feb 01, 2024 at 03:38:37AM +0000, Dharma.B@microchip.com wrote: >> Hi Rob, >> >> On 31/01/24 9:05 am, Dharma B - I70843 wrote: >>> Converted the text bindings to YAML and validated them individually using following commands >>> >>> $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ >>> $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ >>> >>> changelogs are available in respective patches. >>> >>> As Sam suggested I'm sending the PWM binding as it is in this patch series, clean up patch >>> will be sent as separate patch. >>> >> >> I would want to know if I can have the examples in display and pwm >> bindings separately or if I have to delete them from both and have a >> single, comprehensive example in mfd binding. I'm a little puzzled about >> this. > > The strong preference is 1 complete example in the MFD binding. That > avoids 2 copies of the same thing, issues with incomplete examples, > and temporary warnings bisecting the series. Sure, I will drop the examples in display and pwm bindings while sending v6.