[v4,0/2] drm/imx/dcss: implement region request and devres

Message

Philipp Stanner Jan. 24, 2024, 11:19 a.m. UTC

@Laurentiu:
Thank you very much for the review. I was indeed on an older branch. As
Linus's master is currently broken for ARM64 [1], unfortunately, I built
it instead against:
60096f0a77600ac2cc92b82fee279d1905576950

Hope that's fine.


Changes in v4:
- Add Laurentiu's Reviewed-by to patch #1
- Remove unnecsseray struct device pointers from all touched files
- Rebase against newer kernel due to changes in dcss_drv_platform_remove()

Changes in v3:
- Fix build errors (missing variable, forgotten remove to call of deleted
  function)

Changes in v2:
- Add the region-request to this patch-series. That was previously a
  separate patch.

dcss currently does not request its memory resource. This series adds
that request with devres. As we're at it, it also ports all the ioremaps
and associated allocations to devres.

I can build this, but I don't have the hardware available to test it. So
you might want to have a closer look.

P.

[1] https://lore.kernel.org/lkml/45ad1d0f-a10f-483e-848a-76a30252edbe@paulmck-laptop/


Philipp Stanner (2):
  drm/imx/dcss: request memory region
  drm/imx/dcss: have all init functions use devres

 drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 13 ++-----------
 drivers/gpu/drm/imx/dcss/dcss-ctxld.c  | 14 +++-----------
 drivers/gpu/drm/imx/dcss/dcss-dev.c    | 19 +++++++++----------
 drivers/gpu/drm/imx/dcss/dcss-dev.h    |  1 -
 drivers/gpu/drm/imx/dcss/dcss-dpr.c    | 21 +++------------------
 drivers/gpu/drm/imx/dcss/dcss-drv.c    | 12 +++---------
 drivers/gpu/drm/imx/dcss/dcss-dtg.c    | 26 +++++---------------------
 drivers/gpu/drm/imx/dcss/dcss-scaler.c | 21 +++------------------
 drivers/gpu/drm/imx/dcss/dcss-ss.c     | 12 +++---------
 9 files changed, 31 insertions(+), 108 deletions(-)

Comments

Laurentiu Palcu Feb. 2, 2024, 1:54 p.m. UTC | #1

Hi Philipp,

Applied series to drm-misc-next.

Thanks,
Laurentiu

On Wed, Jan 24, 2024 at 12:19:03PM +0100, Philipp Stanner wrote:
> @Laurentiu:
> Thank you very much for the review. I was indeed on an older branch. As
> Linus's master is currently broken for ARM64 [1], unfortunately, I built
> it instead against:
> 60096f0a77600ac2cc92b82fee279d1905576950
> 
> Hope that's fine.
> 
> 
> Changes in v4:
> - Add Laurentiu's Reviewed-by to patch #1
> - Remove unnecsseray struct device pointers from all touched files
> - Rebase against newer kernel due to changes in dcss_drv_platform_remove()
> 
> Changes in v3:
> - Fix build errors (missing variable, forgotten remove to call of deleted
>   function)
> 
> Changes in v2:
> - Add the region-request to this patch-series. That was previously a
>   separate patch.
> 
> dcss currently does not request its memory resource. This series adds
> that request with devres. As we're at it, it also ports all the ioremaps
> and associated allocations to devres.
> 
> I can build this, but I don't have the hardware available to test it. So
> you might want to have a closer look.
> 
> P.
> 
> [1] https://lore.kernel.org/lkml/45ad1d0f-a10f-483e-848a-76a30252edbe@paulmck-laptop/
> 
> 
> Philipp Stanner (2):
>   drm/imx/dcss: request memory region
>   drm/imx/dcss: have all init functions use devres
> 
>  drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 13 ++-----------
>  drivers/gpu/drm/imx/dcss/dcss-ctxld.c  | 14 +++-----------
>  drivers/gpu/drm/imx/dcss/dcss-dev.c    | 19 +++++++++----------
>  drivers/gpu/drm/imx/dcss/dcss-dev.h    |  1 -
>  drivers/gpu/drm/imx/dcss/dcss-dpr.c    | 21 +++------------------
>  drivers/gpu/drm/imx/dcss/dcss-drv.c    | 12 +++---------
>  drivers/gpu/drm/imx/dcss/dcss-dtg.c    | 26 +++++---------------------
>  drivers/gpu/drm/imx/dcss/dcss-scaler.c | 21 +++------------------
>  drivers/gpu/drm/imx/dcss/dcss-ss.c     | 12 +++---------
>  9 files changed, 31 insertions(+), 108 deletions(-)
> 
> -- 
> 2.43.0
>