| Message ID | 20240201-visionox-vtdr-prev-first-v2-1-32db52867624@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag | expand |
On 02/02/2024 01:10, Jessica Zhang wrote: > The DSI host must be enabled for the panel to be initialized in > prepare(). Set the prepare_prev_first flag to guarantee this. > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > To: Neil Armstrong <neil.armstrong@linaro.org> > To: Sam Ravnborg <sam@ravnborg.org> > To: David Airlie <airlied@gmail.com> > To: Daniel Vetter <daniel@ffwll.ch> > To: Jessica Zhang <quic_jesszhan@quicinc.com> > To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > To: Maxime Ripard <mripard@kernel.org> > To: Thomas Zimmermann <tzimmermann@suse.de> > Cc: quic_abhinavk@quicinc.com > Cc: quic_parellan@quicinc.com > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > > Changes in v2: > - Corrected commit message to mention that DCS on commands are sent during > prepare() instead of probe() > - Dropped Fixes tag > - Rebased onto tip of linux-next > - Link to v1: https://lore.kernel.org/r/20230725-visionox-vtdr-prev-first-v1-1-3bc44cec7dc6@quicinc.com > --- > drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c > index a23407b9f6fb6..540099253e1bd 100644 > --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c > +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c > @@ -287,6 +287,7 @@ static int visionox_vtdr6130_probe(struct mipi_dsi_device *dsi) > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_NO_EOT_PACKET | > MIPI_DSI_CLOCK_NON_CONTINUOUS; > + ctx->panel.prepare_prev_first = true; > > drm_panel_init(&ctx->panel, dev, &visionox_vtdr6130_panel_funcs, > DRM_MODE_CONNECTOR_DSI); > > --- > base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 > change-id: 20230717-visionox-vtdr-prev-first-e00ae02eec9f > > Best regards, Thx for resending, it's time to merge those. Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Thu, 01 Feb 2024 16:10:15 -0800, Jessica Zhang wrote: > The DSI host must be enabled for the panel to be initialized in > prepare(). Set the prepare_prev_first flag to guarantee this. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag https://cgit.freedesktop.org/drm/drm-misc/commit/?id=0581bcc48048924f021fa8fae54353402c5d3740
diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c index a23407b9f6fb6..540099253e1bd 100644 --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c @@ -287,6 +287,7 @@ static int visionox_vtdr6130_probe(struct mipi_dsi_device *dsi) dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_CLOCK_NON_CONTINUOUS; + ctx->panel.prepare_prev_first = true; drm_panel_init(&ctx->panel, dev, &visionox_vtdr6130_panel_funcs, DRM_MODE_CONNECTOR_DSI);
The DSI host must be enabled for the panel to be initialized in prepare(). Set the prepare_prev_first flag to guarantee this. Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> --- To: Neil Armstrong <neil.armstrong@linaro.org> To: Sam Ravnborg <sam@ravnborg.org> To: David Airlie <airlied@gmail.com> To: Daniel Vetter <daniel@ffwll.ch> To: Jessica Zhang <quic_jesszhan@quicinc.com> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> To: Maxime Ripard <mripard@kernel.org> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: quic_abhinavk@quicinc.com Cc: quic_parellan@quicinc.com Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Changes in v2: - Corrected commit message to mention that DCS on commands are sent during prepare() instead of probe() - Dropped Fixes tag - Rebased onto tip of linux-next - Link to v1: https://lore.kernel.org/r/20230725-visionox-vtdr-prev-first-v1-1-3bc44cec7dc6@quicinc.com --- drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20230717-visionox-vtdr-prev-first-e00ae02eec9f Best regards,