diff mbox series

ALSA: core: fix unit test dependencies

Message ID 20240204212135.3158722-1-arnd@kernel.org (mailing list archive)
State New, archived
Headers show
Series ALSA: core: fix unit test dependencies | expand

Commit Message

Arnd Bergmann Feb. 4, 2024, 9:21 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The Kunit tests fail to link when PCM support is disabled:

aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_pcm_format_name':
sound_kunit.c:(.text+0x4c): undefined reference to `snd_pcm_format_name'
aarch64-linux-ld: sound_kunit.c:(.text+0x12c): undefined reference to `snd_pcm_format_name'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `_test_fill_silence':
sound_kunit.c:(.text+0x284): undefined reference to `snd_pcm_format_set_silence'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_signed':
sound_kunit.c:(.text+0x400): undefined reference to `snd_pcm_format_signed'
aarch64-linux-ld: sound_kunit.c:(.text+0x470): undefined reference to `snd_pcm_format_unsigned'
aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_width':
sound_kunit.c:(.text+0x64c): undefined reference to `snd_pcm_format_width'
aarch64-linux-ld: sound_kunit.c:(.text+0x71c): undefined reference to `snd_pcm_format_width'

Add the appropriate dependencies.

Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/core/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Takashi Iwai Feb. 5, 2024, 7:08 a.m. UTC | #1 
On Sun, 04 Feb 2024 22:21:29 +0100,
Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The Kunit tests fail to link when PCM support is disabled:
> 
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_pcm_format_name':
> sound_kunit.c:(.text+0x4c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound_kunit.c:(.text+0x12c): undefined reference to `snd_pcm_format_name'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `_test_fill_silence':
> sound_kunit.c:(.text+0x284): undefined reference to `snd_pcm_format_set_silence'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_signed':
> sound_kunit.c:(.text+0x400): undefined reference to `snd_pcm_format_signed'
> aarch64-linux-ld: sound_kunit.c:(.text+0x470): undefined reference to `snd_pcm_format_unsigned'
> aarch64-linux-ld: sound/core/sound_kunit.o: in function `test_format_width':
> sound_kunit.c:(.text+0x64c): undefined reference to `snd_pcm_format_width'
> aarch64-linux-ld: sound_kunit.c:(.text+0x71c): undefined reference to `snd_pcm_format_width'
> 
> Add the appropriate dependencies.
> 
> Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, but this was already fixed on for-next branch.


Takashi
diff mbox series

Patch

diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 664c6ee2b5a1..9a44f259ccca 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -42,6 +42,7 @@  config SND_UMP_LEGACY_RAWMIDI
 config SND_CORE_TEST
 	tristate "Sound core KUnit test"
 	depends on KUNIT
+	depends on SND_PCM
 	default KUNIT_ALL_TESTS
 	help
 	  This options enables the sound core functions KUnit test.