| Message ID | 20240202212448.74840-2-m.shams@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3197329072f0ed2b1272af98ad4299a290036f65 |
| Headers | show |
| Series | [1/2] serial: samsung: honor fifosize from dts at first | expand |
On 02/02/2024 22:24, Tamseel Shams wrote: > UART in FSD SoC has fifosize of 64 bytes. > Set fifosize as 64 bytes for UART from Device Tree. > > Signed-off-by: Tamseel Shams <m.shams@samsung.com> > --- > arch/arm64/boot/dts/tesla/fsd.dtsi | 2 ++ Please split SoC changes from patches sent to serial, so it will be easy to apply for Greg and others. Unless you want to say that there is dependency, but there cannot be such - it would be a NAK. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: 05 February 2024 13:11 > To: Tamseel Shams <m.shams@samsung.com>; alim.akhtar@samsung.com; > linux-fsd@tesla.com; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; > gregkh@linuxfoundation.org; jirislaby@kernel.org > Cc: linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-serial@vger.kernel.org > Subject: Re: [PATCH 2/2] arm64: dts: fsd: Add fifosize for UART in Device Tree > > On 02/02/2024 22:24, Tamseel Shams wrote: > > UART in FSD SoC has fifosize of 64 bytes. > > Set fifosize as 64 bytes for UART from Device Tree. > > > > Signed-off-by: Tamseel Shams <m.shams@samsung.com> > > --- > > arch/arm64/boot/dts/tesla/fsd.dtsi | 2 ++ > > Please split SoC changes from patches sent to serial, so it will be easy to apply > for Greg and others. > > Unless you want to say that there is dependency, but there cannot be such - > it would be a NAK. > Thanks for review. Will take care of this the next version. Thanks & Regards, Tamseel Shams
diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi index aaffb50b8b60..047a83cee603 100644 --- a/arch/arm64/boot/dts/tesla/fsd.dtsi +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi @@ -601,6 +601,7 @@ clocks = <&clock_peric PERIC_PCLK_UART0>, <&clock_peric PERIC_SCLK_UART0>; clock-names = "uart", "clk_uart_baud0"; + samsung,uart-fifosize = <64>; status = "disabled"; }; @@ -613,6 +614,7 @@ clocks = <&clock_peric PERIC_PCLK_UART1>, <&clock_peric PERIC_SCLK_UART1>; clock-names = "uart", "clk_uart_baud0"; + samsung,uart-fifosize = <64>; status = "disabled"; };
UART in FSD SoC has fifosize of 64 bytes. Set fifosize as 64 bytes for UART from Device Tree. Signed-off-by: Tamseel Shams <m.shams@samsung.com> --- arch/arm64/boot/dts/tesla/fsd.dtsi | 2 ++ 1 file changed, 2 insertions(+)