Message ID | 20240130234634.work.003-kees@kernel.org (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | MAINTAINERS: Add UBSAN section | expand |
On Wed, Jan 31, 2024 at 12:46 AM Kees Cook <keescook@chromium.org> wrote: > > The kernel hardening efforts have continued to depend more and more > heavily on UBSAN, so make an actual MAINTAINERS entry for it. > > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > Cc: Marco Elver <elver@google.com> > Cc: Andrey Konovalov <andreyknvl@gmail.com> > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > Hi! I figured since I've been carrying UBSAN changes more and more lately, > I would just make an actual entry in MAINTAINERS. Are you all interested > in being listed as reviewers? Or would you want to be M: instead? > --- > MAINTAINERS | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8d1052fa6a69..19b8802b2f12 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -22471,6 +22471,22 @@ F: Documentation/block/ublk.rst > F: drivers/block/ublk_drv.c > F: include/uapi/linux/ublk_cmd.h > > +UBSAN > +M: Kees Cook <keescook@chromium.org> > +R: Andrey Ryabinin <ryabinin.a.a@gmail.com> > +R: Marco Elver <elver@google.com> > +R: Andrey Konovalov <andreyknvl@gmail.com> > +L: linux-hardening@vger.kernel.org > +S: Supported > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening > +F: Documentation/dev-tools/ubsan.rst > +F: include/linux/ubsan.h > +F: lib/Kconfig.ubsan > +F: lib/test_ubsan.c > +F: lib/ubsan.c > +F: scripts/Makefile.ubsan > +K: \bARCH_HAS_UBSAN\b > + > UCLINUX (M68KNOMMU AND COLDFIRE) > M: Greg Ungerer <gerg@linux-m68k.org> > L: linux-m68k@lists.linux-m68k.org > -- > 2.34.1 > Hi Kees, Perhaps, it also makes sense to add the kasan-dev@googlegroups.com list. It's used for all other Sanitizers. Otherwise, looks good to me: Acked-by: Andrey Konovalov <andreyknvl@gmail.com> Thanks!
On Wed, Jan 31, 2024 at 02:41:16AM +0100, Andrey Konovalov wrote: > On Wed, Jan 31, 2024 at 12:46 AM Kees Cook <keescook@chromium.org> wrote: > > > > The kernel hardening efforts have continued to depend more and more > > heavily on UBSAN, so make an actual MAINTAINERS entry for it. > > > > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > > Cc: Marco Elver <elver@google.com> > > Cc: Andrey Konovalov <andreyknvl@gmail.com> > > Signed-off-by: Kees Cook <keescook@chromium.org> > > --- > > Hi! I figured since I've been carrying UBSAN changes more and more lately, > > I would just make an actual entry in MAINTAINERS. Are you all interested > > in being listed as reviewers? Or would you want to be M: instead? > > --- > > MAINTAINERS | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 8d1052fa6a69..19b8802b2f12 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -22471,6 +22471,22 @@ F: Documentation/block/ublk.rst > > F: drivers/block/ublk_drv.c > > F: include/uapi/linux/ublk_cmd.h > > > > +UBSAN > > +M: Kees Cook <keescook@chromium.org> > > +R: Andrey Ryabinin <ryabinin.a.a@gmail.com> > > +R: Marco Elver <elver@google.com> > > +R: Andrey Konovalov <andreyknvl@gmail.com> > > +L: linux-hardening@vger.kernel.org > > +S: Supported > > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening > > +F: Documentation/dev-tools/ubsan.rst > > +F: include/linux/ubsan.h > > +F: lib/Kconfig.ubsan > > +F: lib/test_ubsan.c > > +F: lib/ubsan.c > > +F: scripts/Makefile.ubsan > > +K: \bARCH_HAS_UBSAN\b > > + > > UCLINUX (M68KNOMMU AND COLDFIRE) > > M: Greg Ungerer <gerg@linux-m68k.org> > > L: linux-m68k@lists.linux-m68k.org > > -- > > 2.34.1 > > > > Hi Kees, > > Perhaps, it also makes sense to add the kasan-dev@googlegroups.com > list. It's used for all other Sanitizers. Okay, sure, I can add that. If it gets too noisy, we can always remove it. :) > > Otherwise, looks good to me: > > Acked-by: Andrey Konovalov <andreyknvl@gmail.com> Thanks!
On Wed, 31 Jan 2024 at 00:46, Kees Cook <keescook@chromium.org> wrote: > > The kernel hardening efforts have continued to depend more and more > heavily on UBSAN, so make an actual MAINTAINERS entry for it. > > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > Cc: Marco Elver <elver@google.com> > Cc: Andrey Konovalov <andreyknvl@gmail.com> > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > Hi! I figured since I've been carrying UBSAN changes more and more lately, > I would just make an actual entry in MAINTAINERS. Are you all interested > in being listed as reviewers? Or would you want to be M: instead? Sure, if it helps: Acked-by: Marco Elver <elver@google.com> Thanks, -- Marco > --- > MAINTAINERS | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8d1052fa6a69..19b8802b2f12 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -22471,6 +22471,22 @@ F: Documentation/block/ublk.rst > F: drivers/block/ublk_drv.c > F: include/uapi/linux/ublk_cmd.h > > +UBSAN > +M: Kees Cook <keescook@chromium.org> > +R: Andrey Ryabinin <ryabinin.a.a@gmail.com> > +R: Marco Elver <elver@google.com> > +R: Andrey Konovalov <andreyknvl@gmail.com> > +L: linux-hardening@vger.kernel.org > +S: Supported > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening > +F: Documentation/dev-tools/ubsan.rst > +F: include/linux/ubsan.h > +F: lib/Kconfig.ubsan > +F: lib/test_ubsan.c > +F: lib/ubsan.c > +F: scripts/Makefile.ubsan > +K: \bARCH_HAS_UBSAN\b > + > UCLINUX (M68KNOMMU AND COLDFIRE) > M: Greg Ungerer <gerg@linux-m68k.org> > L: linux-m68k@lists.linux-m68k.org > -- > 2.34.1 >
On Tue, Jan 30, 2024 at 03:46:38PM -0800, Kees Cook wrote: > The kernel hardening efforts have continued to depend more and more > heavily on UBSAN, so make an actual MAINTAINERS entry for it. > > Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> I don't see Andrey on lkml in almost a year, so I'll drop the entry for now. Andrey, if you want to be added, just say the word! :) -Kees > Cc: Marco Elver <elver@google.com> > Cc: Andrey Konovalov <andreyknvl@gmail.com> > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > Hi! I figured since I've been carrying UBSAN changes more and more lately, > I would just make an actual entry in MAINTAINERS. Are you all interested > in being listed as reviewers? Or would you want to be M: instead? > --- > MAINTAINERS | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8d1052fa6a69..19b8802b2f12 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -22471,6 +22471,22 @@ F: Documentation/block/ublk.rst > F: drivers/block/ublk_drv.c > F: include/uapi/linux/ublk_cmd.h > > +UBSAN > +M: Kees Cook <keescook@chromium.org> > +R: Andrey Ryabinin <ryabinin.a.a@gmail.com> > +R: Marco Elver <elver@google.com> > +R: Andrey Konovalov <andreyknvl@gmail.com> > +L: linux-hardening@vger.kernel.org > +S: Supported > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening > +F: Documentation/dev-tools/ubsan.rst > +F: include/linux/ubsan.h > +F: lib/Kconfig.ubsan > +F: lib/test_ubsan.c > +F: lib/ubsan.c > +F: scripts/Makefile.ubsan > +K: \bARCH_HAS_UBSAN\b > + > UCLINUX (M68KNOMMU AND COLDFIRE) > M: Greg Ungerer <gerg@linux-m68k.org> > L: linux-m68k@lists.linux-m68k.org > -- > 2.34.1 >
On 2/2/24 10:55, Kees Cook wrote: > On Tue, Jan 30, 2024 at 03:46:38PM -0800, Kees Cook wrote: >> The kernel hardening efforts have continued to depend more and more >> heavily on UBSAN, so make an actual MAINTAINERS entry for it. >> >> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > > I don't see Andrey on lkml in almost a year, so I'll drop the entry for > now. Andrey, if you want to be added, just say the word! :) > > -Kees > I occasionally read that stuff, so I'd appreciate if you'd kept me in ;)
On Mon, Feb 05, 2024 at 01:54:08PM +0100, Andrey Ryabinin wrote: > > > On 2/2/24 10:55, Kees Cook wrote: > > On Tue, Jan 30, 2024 at 03:46:38PM -0800, Kees Cook wrote: > >> The kernel hardening efforts have continued to depend more and more > >> heavily on UBSAN, so make an actual MAINTAINERS entry for it. > >> > >> Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> > > > > I don't see Andrey on lkml in almost a year, so I'll drop the entry for > > now. Andrey, if you want to be added, just say the word! :) > > I occasionally read that stuff, so I'd appreciate if you'd kept me in ;) You got it! :) I appreciate having more eyes on it. I'll add you back.
diff --git a/MAINTAINERS b/MAINTAINERS index 8d1052fa6a69..19b8802b2f12 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22471,6 +22471,22 @@ F: Documentation/block/ublk.rst F: drivers/block/ublk_drv.c F: include/uapi/linux/ublk_cmd.h +UBSAN +M: Kees Cook <keescook@chromium.org> +R: Andrey Ryabinin <ryabinin.a.a@gmail.com> +R: Marco Elver <elver@google.com> +R: Andrey Konovalov <andreyknvl@gmail.com> +L: linux-hardening@vger.kernel.org +S: Supported +T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/hardening +F: Documentation/dev-tools/ubsan.rst +F: include/linux/ubsan.h +F: lib/Kconfig.ubsan +F: lib/test_ubsan.c +F: lib/ubsan.c +F: scripts/Makefile.ubsan +K: \bARCH_HAS_UBSAN\b + UCLINUX (M68KNOMMU AND COLDFIRE) M: Greg Ungerer <gerg@linux-m68k.org> L: linux-m68k@lists.linux-m68k.org
The kernel hardening efforts have continued to depend more and more heavily on UBSAN, so make an actual MAINTAINERS entry for it. Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com> Cc: Marco Elver <elver@google.com> Cc: Andrey Konovalov <andreyknvl@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org> --- Hi! I figured since I've been carrying UBSAN changes more and more lately, I would just make an actual entry in MAINTAINERS. Are you all interested in being listed as reviewers? Or would you want to be M: instead? --- MAINTAINERS | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)