| Message ID | 20240205101400.1480521-9-leitao@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: Fix MODULE_DESCRIPTION() for net (p5) | expand |
Hi Breno, Please be more cautious with your titles. It's your second or third e-mail with this content without version number. And you also forgot to collect Stefan Ack. leitao@debian.org wrote on Mon, 5 Feb 2024 02:13:57 -0800: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to the IEEE 802.15.4 socket and 6lowpan modules. > > Signed-off-by: Breno Leitao <leitao@debian.org> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
Hello Miquel, On Mon, Feb 05, 2024 at 02:41:18PM +0100, Miquel Raynal wrote: > Hi Breno, > > Please be more cautious with your titles. It's your second or third > e-mail with this content without version number. And you also forgot to > collect Stefan Ack. Sorry, in fact, the commit you are referring to is already in landed net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=6aa89bf8ac9a The problem here is that this commit shouldn't be against net, since it is already net-next. This workstream was applied part in net, and part in net-next. I am trying to focus in fixing all the warning in "net" and not touch those in net-next. This commit is already in net-next, but, and shouldn't be in `net`. I will resend the patch without it. Sorry if this caused any confusion.
diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c index 2c087b7f17c5..d19bc9314374 100644 --- a/net/ieee802154/6lowpan/core.c +++ b/net/ieee802154/6lowpan/core.c @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void) module_init(lowpan_init_module); module_exit(lowpan_cleanup_module); +MODULE_DESCRIPTION("IEEE 802.15.4 IPv6 over Low-Power Wireless Personal Area Network module"); MODULE_LICENSE("GPL"); MODULE_ALIAS_RTNL_LINK("lowpan"); diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c index 00302e8b9615..a93b592c2f83 100644 --- a/net/ieee802154/socket.c +++ b/net/ieee802154/socket.c @@ -1136,5 +1136,6 @@ static void __exit af_ieee802154_remove(void) module_init(af_ieee802154_init); module_exit(af_ieee802154_remove); +MODULE_DESCRIPTION("IEEE 802.15.4 socket interface"); MODULE_LICENSE("GPL"); MODULE_ALIAS_NETPROTO(PF_IEEE802154);
W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). Add descriptions to the IEEE 802.15.4 socket and 6lowpan modules. Signed-off-by: Breno Leitao <leitao@debian.org> --- net/ieee802154/6lowpan/core.c | 1 + net/ieee802154/socket.c | 1 + 2 files changed, 2 insertions(+)