| Message ID | 20240110093343.468810-1-alexander.stein@ew.tq-group.com |
|---|---|
| State | Accepted |
| Commit | 7936378cb6d87073163130e1e1fc1e5f76a597cf |
| Headers | show |
| Series | [v2,1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes | expand |
Hi everyone, Am Mittwoch, 10. Januar 2024, 10:33:43 CET schrieb Alexander Stein: > Devicetree spec lists only dashes as valid characters for alias names. > Table 3.2: Valid characters for alias names, Devicee Specification, > Release v0.4 > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > Fixes: 3fbae284887de ("phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp > LVDS PHY mode support") > --- > Changes in v2: > * Added Fixes tag as suggested by Liu Ying Any feedback on this? Thanks and best regards, Alexander > drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index > e625b32889bfc..0928a526e2ab3 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c > @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device > *pdev) return ret; > } > > - priv->id = of_alias_get_id(np, "mipi_dphy"); > + priv->id = of_alias_get_id(np, "mipi-dphy"); > if (priv->id < 0) { > dev_err(dev, "Failed to get phy node alias id: %d\n", > priv->id);
On Wed, 10 Jan 2024 10:33:43 +0100, Alexander Stein wrote: > Devicetree spec lists only dashes as valid characters for alias names. > Table 3.2: Valid characters for alias names, Devicee Specification, > Release v0.4 > > Applied, thanks! [1/1] phy: freescale: phy-fsl-imx8-mipi-dphy: Fix alias name to use dashes commit: 7936378cb6d87073163130e1e1fc1e5f76a597cf Best regards,
diff --git a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c index e625b32889bfc..0928a526e2ab3 100644 --- a/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c +++ b/drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c @@ -706,7 +706,7 @@ static int mixel_dphy_probe(struct platform_device *pdev) return ret; } - priv->id = of_alias_get_id(np, "mipi_dphy"); + priv->id = of_alias_get_id(np, "mipi-dphy"); if (priv->id < 0) { dev_err(dev, "Failed to get phy node alias id: %d\n", priv->id);
Devicetree spec lists only dashes as valid characters for alias names. Table 3.2: Valid characters for alias names, Devicee Specification, Release v0.4 Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Fixes: 3fbae284887de ("phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support") --- Changes in v2: * Added Fixes tag as suggested by Liu Ying drivers/phy/freescale/phy-fsl-imx8-mipi-dphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)